Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Binder symbols in Exists is not linked #91

Closed
eric-wieser opened this issue Nov 19, 2022 · 5 comments
Closed

Binder symbols in Exists is not linked #91

eric-wieser opened this issue Nov 19, 2022 · 5 comments

Comments

@eric-wieser
Copy link
Contributor

Compare:

Only the Lean3 versions let you inspect the binder symbol in the docs. While for Existss this is obvious, for other binders the hover text is very useful.

It's possible this requires a patch to Lean4 itself; the Lean 3 patch was leanprover-community/lean#781.

@hargoniX
Copy link
Collaborator

This does most likely require a patch to lean itself, doc-gen4 merely analyses datastructures on top of the info trees: https://github.com/leanprover/doc-gen4/blob/main/DocGen4/Output/Base.lean#L208

CC: @Kha what do you think?

@Kha
Copy link
Member

Kha commented Nov 19, 2022

Yes, doc-gen shows whatever the info view shows

@kmill
Copy link
Contributor

kmill commented Jan 20, 2025

leanprover/lean4#6704 has a possible fix for this. It modifies the app unexpanders for core notations, adding tags to tokens for the head constant.

@Komyyy's linked pull request solves this in a different way, by using heuristics that replace using pp.tagAppFns.

@Komyyy
Copy link
Contributor

Komyyy commented Jan 21, 2025

leanprover/lean4#6704 has a possible fix for this. It modifies the app unexpanders for core notations, adding tags to tokens for the head constant.

@Komyyy's linked pull request solves this in a different way, by using heuristics that replace using pp.tagAppFns.

This PR is closed because of some problems, leanprover/lean4#6704 will solve this issue.

@kmill
Copy link
Contributor

kmill commented Feb 4, 2025

https://leanprover-community.github.io/mathlib4_docs/Init/PropLemmas.html#exists_eq has a link now on the exists notation.

(App unexpanders in general now have links in their tokens.)

@kmill kmill closed this as completed Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants