fix: grind issues exposed by grind_constProp
#6895
Merged
+78
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and add refactoring TODOs
See comment for justification. This commit also renames `Grind.simp` => `Grind.preprocess`
another mystery solved...
leodemoura
added
the
changelog-language
github-actions
bot
added
the
toolchain-available
|
Mathlib CI status (docs):
|
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 24, 2025
This PR fixes a few `grind` issues exposed by the `grind_constProp.lean` test. - Support for equational theorem hypotheses created before invoking `grind`. Example: applying an induction principle.s - Support of `Unit`-like types. - Missing recursion depth checks.
luisacicolini
pushed a commit
to opencompl/lean4
that referenced
this pull request
Feb 25, 2025
This PR fixes a few `grind` issues exposed by the `grind_constProp.lean` test. - Support for equational theorem hypotheses created before invoking `grind`. Example: applying an induction principle.s - Support of `Unit`-like types. - Missing recursion depth checks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a few
grindissues exposed by thegrind_constProp.leantest.grind. Example: applying an induction principle.sUnit-like types.