Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: attributes [grind =>] and [grind <=] #6897

Merged
merged 9 commits into from
Feb 1, 2025
Merged

feat: attributes [grind =>] and [grind <=] #6897

merged 9 commits into from
Feb 1, 2025

Conversation

leodemoura
Copy link
Member

@leodemoura leodemoura commented Feb 1, 2025 •
edited
Loading

This PR adds the new attributes [grind =>] and [grind <=] for controlling pattern selection and minimizing the number of places where we have to use verbose grind_pattern command. It also fixes a bug in the new pattern selection procedure, and improves the automatic pattern selection for local lemmas.

The tests grind_constProp.lean and no_grind_constProp.lean are the same use case with and without grind.

@leodemoura leodemoura added the changelog-language Language features, tactics, and metaprograms label Feb 1, 2025
@leodemoura leodemoura requested a review from kim-em as a code owner February 1, 2025 04:12
@leodemoura leodemoura enabled auto-merge February 1, 2025 04:12
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 1, 2025 04:19 Inactive
@github-actions github-actions bot temporarily deployed to lean-lang.org/lean4/doc February 1, 2025 04:26 Inactive
@leodemoura leodemoura added this pull request to the merge queue Feb 1, 2025
@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Feb 1, 2025
@leanprover-community-bot
Copy link
Collaborator

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 425c7a12d01087e3dbe8905175187ec94be4b74c --onto ad48761032c5750e51289f3885967c1b6f8edde5. (2025-02-01 04:45:44)

Merged via the queue into master with commit 66471ba Feb 1, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kim-em kim-em Awaiting requested review from kim-em kim-em is a code owner

Assignees
No one assigned
Labels
changelog-language Language features, tactics, and metaprograms toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@leodemoura @leanprover-community-bot