-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display a meaningful error warning when KDS path is not provided when running yarn run devserver-with-kds
#11632
Comments
Hi @MisRob. I'd like to work on this issue. Could you please assign it to me? |
Hi @KshitijThareja, thank you. I'd like to wait to @Jaspreet-singh-1032 for a bit to confirm whether he'd like to work on this since it's a follow-up to his recent work and we talked about continuing some of it. |
@MisRob, thanks for creating this follow-up. Hi @KshitijThareja, If you want to work on it, you can proceed. Feel free to let me know if you need any help. FYI I had added a kds flag in the previous PR to know if the yarn command is run using |
Thanks @Jaspreet-singh-1032. I'd definitely approach you if I need any help. And thanks for your suggestion too, I'll look into it. |
Okay, thanks both :) Assigning you, @KshitijThareja |
@KshitijThareja I've just merged @Jaspreet-singh-1032 PR #11446 to the release branch so it should be now available for further work |
Closed by #11657 |
This is a follow-up to #11446 which introduced
devserver-with-kds
package.json command. This command requires KDS path being specified, e.g.yarn run devserver-with-kds /path/to/kolibri-design-system
.Currently, when we forget to specify the KDS path and run only
yarn run devserver-with-kds
, unless one is familiar with the command in detail, it is hard to figure out why the command doesn't work as expected.We'd ideally show an error warning when the path is missing.
The text was updated successfully, but these errors were encountered: