Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display a meaningful error warning when KDS path is not provided when running yarn run devserver-with-kds #11632

Closed
MisRob opened this issue Dec 13, 2023 · 7 comments
Assignees
Labels
help wanted Open source contributors welcome TAG: dev experience Build performance, linting, debugging...

Comments

@MisRob
Copy link
Member

MisRob commented Dec 13, 2023

This is a follow-up to #11446 which introduced devserver-with-kds package.json command. This command requires KDS path being specified, e.g. yarn run devserver-with-kds /path/to/kolibri-design-system.

Currently, when we forget to specify the KDS path and run only yarn run devserver-with-kds, unless one is familiar with the command in detail, it is hard to figure out why the command doesn't work as expected.

We'd ideally show an error warning when the path is missing.

@MisRob MisRob added help wanted Open source contributors welcome TAG: dev experience Build performance, linting, debugging... labels Dec 13, 2023
@KshitijThareja
Copy link
Contributor

Hi @MisRob. I'd like to work on this issue. Could you please assign it to me?
Thanks :)

@MisRob
Copy link
Member Author

MisRob commented Dec 13, 2023

Hi @KshitijThareja, thank you. I'd like to wait to @Jaspreet-singh-1032 for a bit to confirm whether he'd like to work on this since it's a follow-up to his recent work and we talked about continuing some of it.

@Jaspreet-singh-1032
Copy link
Contributor

@MisRob, thanks for creating this follow-up.

Hi @KshitijThareja, If you want to work on it, you can proceed. Feel free to let me know if you need any help.

FYI I had added a kds flag in the previous PR to know if the yarn command is run using devserver-with-kds. But it was removed later because It was an extra flag and was not needed at that moment. But now I think you will need to add that flag back because otherwise, I think there is not any other way to know if the yarn command is run using devserver or devserver-with-kds. So, I think you can use this approach or try if you have any other ideas.

@KshitijThareja
Copy link
Contributor

Thanks @Jaspreet-singh-1032. I'd definitely approach you if I need any help. And thanks for your suggestion too, I'll look into it.

@MisRob
Copy link
Member Author

MisRob commented Dec 14, 2023

Okay, thanks both :) Assigning you, @KshitijThareja

@MisRob
Copy link
Member Author

MisRob commented Dec 14, 2023

@KshitijThareja I've just merged @Jaspreet-singh-1032 PR #11446 to the release branch so it should be now available for further work

@MisRob
Copy link
Member Author

MisRob commented Feb 15, 2024

Closed by #11657

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Open source contributors welcome TAG: dev experience Build performance, linting, debugging...
Projects
None yet
Development

No branches or pull requests

5 participants