Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the AppBarPage self populate the top nav, based on registered navigation items in in navComponents.js #11731

Closed
7 tasks
Tracked by #5488
rtibbles opened this issue Jan 12, 2024 · 2 comments · Fixed by #12084
Closed
7 tasks
Tracked by #5488

Comments

@rtibbles
Copy link
Member

rtibbles commented Jan 12, 2024

We currently duplicate our specification of navigation items within Kolibri Single Page Apps. Firstly, they are specified in a top nav bar component on a per app basis, which is used to populate the top navigation.

Addtionally, the side navigation specifies not just the top level navigation item, but also all the side navigation items, which are identical to the top navigation items.

To resolve this, we should update the AppBarPage component, or potentially the HorizontalNavBarWithOverflow component, to populate the navigation automatically based on registered items in the navComponents.js

Acceptance Criteria

Preview Give feedback
@dhruvpal05
Copy link

dhruvpal05 commented Jan 16, 2024

I can work on this issue , please assign me this

@rtibbles
Copy link
Member Author

Hi @dhruvpal05 - this has some intersections with other work, so I didn't want this to be worked on just yet. Please have a look for issues with the help wanted label, which are more amenable for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants