-
Notifications
You must be signed in to change notification settings - Fork 738
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Migrated UserTable to KTable (Without Sorting) #13028
base: develop
Are you sure you want to change the base?
Conversation
Build Artifacts
|
@radinamatic here the main focus of QA would be that there are no regressions in the |
It was a bit confusing that filtering and pagination features were affecting both tables... 😂 However all seems to be working without regressions, old ones and new New font size noted by @ozer550 looks good to me 👍🏽 , and the role chip appears below probably because of the same column sizes (which can be changed, iirc). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you @BabyElias! 👍🏽 💯
Summary
Migrated UserTable (as seen in UserPage.vue) to KTable.
This is with reference to #12705 which involves migrating
Facility>Users
table from the current UserTable implementation to KTable. Sorting functionality will be introduced in the next PR; this one focuses on checking any regressions that might have been made while migrating theFacility>Users
table to a KTable-based implementation.References
#12705
Reviewer guidance
Facility>Users
.