Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a placeholder string when no resources are available/no channels on devices #13041

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

marcellamaki
Copy link
Member

Summary

This adds a common string that can be used across Kolibri for situations where there are no channels imported on the device and therefore no resources that are available for the user - whether this is for viewing, or for selecting (i.e. lesson and quiz creation).

References

Fixes #13021

Screenshot 2025-01-29 at 3 34 41 PM

Reviewer guidance

  1. Remove all channels from the device, and ensure that the string displays on the /lessonstemp path when opening the "manage resources" side panel.
  2. When their are channels, the channel cards should display correctly.

@github-actions github-actions bot added APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend labels Jan 29, 2025
@radinamatic
Copy link
Member

/lessonstemp path working as expected with the new string:

2025-01-30_18-09-35

Copy link
Member

@radinamatic radinamatic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍🏽 💯 :shipit:

Copy link
Member

@AlexVelezLl AlexVelezLl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes makes sense to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Coach Re: Coach App (lessons, quizzes, groups, reports, etc.) DEV: frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Manage lesson resources > Search - No indication that there are no imported resources on the device
3 participants