Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leverage new openInNewTab prop of KExternalLink #7712

Closed
indirectlylit opened this issue Dec 2, 2020 · 1 comment
Closed

Leverage new openInNewTab prop of KExternalLink #7712

indirectlylit opened this issue Dec 2, 2020 · 1 comment
Labels
P1 - important Priority: High impact on UX TAG: design system Change to our style guide / design system TAG: ux update Improved user-facing feature
Milestone

Comments

@indirectlylit
Copy link
Contributor

Observed behavior

We're adding a new prop which allows external links to set whether or not they open in a new tab: learningequality/kolibri-design-system#137

KExternalLink is slightly misnamed: it really means "not a Vue router link". It is used for both "internal links" e.g. "Explore without account" on the sign-in page as well truly external links such as to learningequality.org from the privacy policy.

Expected behavior

We should audit our use of KExternalLink and set openInNewTab=true when appropriate.

User-facing consequences

Internal links should stay on the same tab, and truly external links should open in a new tab.

Context

0.14.4

@YashJipkate
Copy link
Contributor

Hi! I would like to work on this issue and have opened a working PR towards this. Please take a look.

Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 - important Priority: High impact on UX TAG: design system Change to our style guide / design system TAG: ux update Improved user-facing feature
Projects
None yet
Development

No branches or pull requests

4 participants