Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guard to /library when no resources are added. #9625

Closed
marcellamaki opened this issue Aug 16, 2022 · 1 comment · Fixed by #9635
Closed

Add guard to /library when no resources are added. #9625

marcellamaki opened this issue Aug 16, 2022 · 1 comment · Fixed by #9635
Assignees
@marcellamaki @thanksameeelian
Labels
P0 - critical Priority: Release blocker or regression TODO: needs gherkin update Add to our manual integration tests
Milestone
Planned Patch 5

Comments

@marcellamaki
Copy link
Member

marcellamaki commented Aug 16, 2022 •
edited
Loading

Observed behavior

Currently on a partner instance, there are no loaded resources, but /library does not redirect correctly, although /home does.

Errors and logs

Perpetual loader

Expected behavior

When there are no resources added to a Kolibri instance, redirect to "No resources available page" (see home page guard for reference).

User-facing consequences

Confusion, concern that something is broken

Steps to reproduce

This can be reproduced by going to the /library page on a Kolibri facility with no resources added to the library

Context

Kolibri 0.15
@marcellamaki marcellamaki added the P0 - critical Priority: Release blocker or regression label Aug 16, 2022
@radinamatic radinamatic added the TODO: needs gherkin update Add to our manual integration tests label Aug 16, 2022
@marcellamaki marcellamaki self-assigned this Aug 16, 2022
@nucleogenesis nucleogenesis added this to the Planned Patch 6 milestone Aug 16, 2022
@marcellamaki marcellamaki mentioned this issue Aug 18, 2022
Merged
9 tasks
@rtibbles rtibbles linked a pull request Aug 19, 2022 that will close this issue
add content check guard to library page #9635
Merged
9 tasks
@rtibbles
Copy link
Member

Fixed in #9635

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcellamaki marcellamaki

@thanksameeelian thanksameeelian

Labels
P0 - critical Priority: Release blocker or regression TODO: needs gherkin update Add to our manual integration tests
Projects
None yet
Milestone
Planned Patch 5
Development

Successfully merging a pull request may close this issue.

add content check guard to library page marcellamaki/kolibri
5 participants
@radinamatic @rtibbles @nucleogenesis @marcellamaki @thanksameeelian