Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swap on-my-own const for using the existing Personal const #11514

Merged

Conversation

marcellamaki
Copy link
Member

@marcellamaki marcellamaki commented Nov 9, 2023

prevent state management snafus

Summary

References

Reviewer guidance


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Sorry, something went wrong.

@marcellamaki marcellamaki changed the title Swap on-my-own const for using the existing Personal const, to preven… Swap on-my-own const for using the existing Personal const Nov 9, 2023
@github-actions github-actions bot added APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) SIZE: small labels Nov 9, 2023
@radinamatic
Copy link
Member

After installing the APK asset from this PR on my Android 9 device and attempted the on-my-own setup, I encountered the same error as in 4. reported previously.

However, once tapped the link Start over in the error, the setup was eventually completed 🤷🏽‍♀️
I repeated the workflow with another, even older device (Android 8), and had no issues with the on-my-own setup, so not sure what's the issue. Attaching logs: kolibri.txt

@marcellamaki marcellamaki requested a review from rtibbles January 15, 2024 22:35
@rtibbles rtibbles self-assigned this Jan 16, 2024
Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does rather feel like a double hack - both removing any use of the ON_MY_OWN value, replacing it with PERSONAL, and also adding the computed prop at the end to make sure we always set the PERSONAL preset in the on my own case.

However, this close to release, better safe than sorry.

One possible cleanup, as I saw an error, that seems to be pre-existing, when going through the flow.

@marcellamaki marcellamaki requested a review from rtibbles January 17, 2024 20:52
@rtibbles
Copy link
Member

Docs build issue is fixed on main branch.

@rtibbles rtibbles merged commit a51a1e7 into learningequality:release-v0.16.x Jan 18, 2024
33 of 34 checks passed
@rtibbles rtibbles mentioned this pull request Jan 23, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
APP: Setup Wizard Re: Setup Wizard (facility import, superuser creation, settings, etc.) DEV: frontend SIZE: medium SIZE: small
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants