-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Swap on-my-own const for using the existing Personal const #11514
Swap on-my-own const for using the existing Personal const #11514
Conversation
Build Artifacts
|
After installing the APK asset from this PR on my Android 9 device and attempted the on-my-own setup, I encountered the same error as in 4. reported previously. However, once tapped the link Start over in the error, the setup was eventually completed 🤷🏽♀️ |
faa8f64
to
c3d0cb1
Compare
…t state management snafus
c3d0cb1
to
a14933c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does rather feel like a double hack - both removing any use of the ON_MY_OWN value, replacing it with PERSONAL, and also adding the computed prop at the end to make sure we always set the PERSONAL preset in the on my own case.
However, this close to release, better safe than sorry.
One possible cleanup, as I saw an error, that seems to be pre-existing, when going through the flow.
kolibri/plugins/setup_wizard/assets/src/views/onboarding-forms/HowAreYouUsingKolibri.vue
Show resolved
Hide resolved
…T_FACILITY_PRESET mutation
Docs build issue is fixed on main branch. |
a51a1e7
into
learningequality:release-v0.16.x
prevent state management snafus
Summary
…
References
…
Reviewer guidance
…
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)