Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update development documentation #11917

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Feb 23, 2024

Summary

Also see related learningequality/kolibri-design-system#557


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Sorry, something went wrong.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@MisRob MisRob added the TODO: needs review Waiting for review label Feb 23, 2024
@MisRob MisRob marked this pull request as ready for review February 23, 2024 08:48
@MisRob MisRob added the TAG: developer docs Technical docs and code comments label Feb 23, 2024
Copy link
Member

@AllanOXDi AllanOXDi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @MisRob , The changes looks good to me.

Copy link
Member

@rtibbles rtibbles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs code changes look good, and looking at the the readthedocs preview build, both pages now appear!

@rtibbles rtibbles merged commit bc9c053 into learningequality:develop Feb 23, 2024
31 checks passed
@MisRob MisRob deleted the update-devdocs branch February 29, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
SIZE: small TAG: developer docs Technical docs and code comments TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants