Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to fix GH notification action #11928

Merged
merged 1 commit into from
Mar 1, 2024

Conversation

MisRob
Copy link
Member

@MisRob MisRob commented Feb 29, 2024

Summary

The action is still broken, see https://learningequality.slack.com/archives/CB37UM23A/p1709043421448809?thread_ts=1708938068.560799&cid=CB37UM23A

References

Follow-up to

Reviewer guidance

This has been reviewed in #11902 already before we experimented with toJSON, so I think we can merge and see if it works.


Testing checklist

  • Contributor has fully tested the PR manually
  • If there are any front-end changes, before/after screenshots are included
  • Critical user journeys are covered by Gherkin stories
  • Critical and brittle code paths are covered by unit tests

PR process

  • PR has the correct target branch and milestone
  • PR has 'needs review' or 'work-in-progress' label
  • If PR is ready for review, a reviewer has been added. (Don't use 'Assignees')
  • If this is an important user-facing change, PR or related issue has a 'changelog' label
  • If this includes an internal dependency change, a link to the diff is provided

Reviewer checklist

  • Automated test coverage is satisfactory
  • PR is fully functional
  • PR has been tested for accessibility regressions
  • External dependency files were updated if necessary (yarn and pip)
  • Documentation is updated
  • Contributor is in AUTHORS.md

Sorry, something went wrong.

@github-actions github-actions bot added DEV: dev-ops Continuous integration & deployment SIZE: very small labels Feb 29, 2024
@MisRob MisRob requested review from rtibbles and vkWeb February 29, 2024 08:21
@MisRob MisRob added the TODO: needs review Waiting for review label Feb 29, 2024
@rtibbles rtibbles merged commit 4dae628 into learningequality:develop Mar 1, 2024
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DEV: dev-ops Continuous integration & deployment SIZE: very small TODO: needs review Waiting for review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants