-
Notifications
You must be signed in to change notification settings - Fork 750
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add new documentation related to testing style guide and testing template #12083
Conversation
Build Artifacts
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your work here @EshaanAgg! This is looking great, these are some thoughts from an initial reading. But it's definitely looking good.
Thanks, @MisRob and @AlexVelezLl, for all the help. I have updated the documentation as per the review comments. I also took the liberty to make two more changes:
Let me know if you would like to see something else added! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @EshaanAgg! Thank you for all your great work here. Sorry for the delay in the review. And Sorry for the back and forth. I think this will be the last before approval from my side. It's pretty polished already 🎉.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for all your hard work here @EshaanAgg!! 🎉. In the future we could edit the documentation and cover some point that we might be missing, but for now it looks pretty good. The style guide shows the what and how quite well. The testing template looks quite good and complete for multiple cases, and the structure in general seems adequate and easy to follow!! LGTM! Thank you 🚀🚀🚀.
Summary
Adds
References
Slack Discussion
Reviewer guidance
Testing checklist
PR process
Reviewer checklist
yarn
andpip
)