We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The max length for tags in Studio is 50, but it is 30 in Kolibri.
We should not publish channels that will break Kolibri when importing.
At the very least, we should exclude or truncate longer tags at import.
We should also update the frontend and API validation to max at 30 to prevent any new tags.
We will then need to come up with a migration plan for existing tags that are too long.
Impossible to import channels into strict database engines (i.e. postgresql).
The text was updated successfully, but these errors were encountered:
I think I can look into this...?
Sorry, something went wrong.
That would be great, @vkWeb - the publishing code is in here: https://github.com/learningequality/studio/blob/unstable/contentcuration/contentcuration/utils/publish.py so the most important thing is to just not include tags greater than 30 characters when we publish as a first step.
We can then do further things to help rectify this issue!
studio/contentcuration/kolibri_content/models.py
Line 62 in bedd893
@rtibbles max_length is restricted to 30 on the ContentTag model 🤔...?
max_length
ContentTag
That is the export model - but it's also SQLite, so it doesn't get enforced at the database level, so can still be written.
The tag class for Studio specifies a max length of 50: https://github.com/learningequality/studio/blob/unstable/contentcuration/contentcuration/models.py#L1019
vkWeb
Successfully merging a pull request may close this issue.
Observed behavior
The max length for tags in Studio is 50, but it is 30 in Kolibri.
Expected behavior
We should not publish channels that will break Kolibri when importing.
At the very least, we should exclude or truncate longer tags at import.
We should also update the frontend and API validation to max at 30 to prevent any new tags.
We will then need to come up with a migration plan for existing tags that are too long.
User-facing consequences
Impossible to import channels into strict database engines (i.e. postgresql).
The text was updated successfully, but these errors were encountered: