Unstable - Deleted folders/resources keep reappearing

[pcenov]

Observed behavior

I've been noticing cases where deleted folders/resources reappear after a certain sequence of actions.
For example if I delete several folders and I click Add > New folder I do see the folders reappearing but this is not always the case.
Also after signing out and signing in again I can see folders that I've previously deleted.

Expected behavior

Deleted folders should not reappear.

Steps to reproduce the issue

1. Go to https://unstable.studio.learningequality.org/en/accounts/#/ and sign in
2. Go to Edit channel delete some folders and then click Add > New folder

Additional information

2022-08-10_19-02-34.mp4

Usage Details

• OS: Windows 10
• Browser: Chrome, Firefox
• URL: https://unstable.studio.learningequality.org/

[pcenov]

@radinamatic

[bjester]

I think I understand what's happening here-- our tree insert logic needs access to the sibling nodes. Since all of the folders were deleted, no siblings were found so it loaded them from the server, but the server hadn't necessarily applied the changes that deleted them yet.

[pcenov]

I've updated the description to include 'resources' as well. Also noticed that if I share a channel with deleted folders/resources with a peer the peer is able to see the deleted folders/resources which is quite confusing.