Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hotfixes - Resources are treated as incomplete when Completion > When time spent is equal to duration is selected #3751

Closed
pcenov opened this issue Oct 19, 2022 · 4 comments · Fixed by #3767 or #3781
Assignees
Labels
P0 - critical Priority: Release blocker or regression

Comments

@pcenov
Copy link
Member

pcenov commented Oct 19, 2022

Observed behavior

This one is extremely confusing and I'm not always able to replicate it. It seems to be valid for resources of type .EPUB .ZIP, MP4, Exercise. The user is able to select 'Completion > When time spent is equal to duration' but after exiting the edit modal the resource gets marked as incomplete without clear indication what is incomplete. After further investigation it turns out that the Duration field disappears but again, not always.

Expected behavior

Fully functional Completion functionality

Steps to reproduce the issue

  1. Go to https://hotfixes.studio.learningequality.org/en/accounts/#/ and sign in
  2. Create a new channel and upload a .EPUB MP4, .ZIP file
  3. Set the Completion to When time spent is equal to duration and Duration to Long activity.
  4. Exit the edit modal.

Additional information

EPUB:
https://user-images.githubusercontent.com/79847249/196691536-fd26706d-ac0e-4139-b90a-24abf8dab20a.mp4
ZIP:
https://user-images.githubusercontent.com/79847249/196700145-deadbd86-4dc8-420e-8ef4-a527a776f0eb.mp4

Usage Details

@pcenov
Copy link
Member Author

pcenov commented Oct 19, 2022

@bjester and @radinamatic

@marcellamaki marcellamaki self-assigned this Oct 19, 2022
@bjester bjester added the P0 - critical Priority: Release blocker or regression label Oct 20, 2022
@pcenov
Copy link
Member Author

pcenov commented Oct 26, 2022

@marcellamaki while verifying this fix I noticed that now when creating and HTML resource it is possible for the 'Determined by resource' to be stored as value however when I open the resource in edit mode the Duration drop-down is also displayed.
Mentioning this here as suggested by you in Slack.

2022-10-26_13-23-47.mp4

@pcenov
Copy link
Member Author

pcenov commented Oct 26, 2022

Also flagging that a similar problem is observed when saving a pdf resource as 'Reference' material for which progress should not be tracked, however when I open the resource in edit mode the value in the Completion drop-down is changed to 'Viewed in its entirety'. After importing the resource in Kolibri it is correctly displayed as a reference material however it gets marked as Completed if I open to view it and I even get points for it:

2022-10-26_13-49-07.mp4

@rtibbles
Copy link
Member

rtibbles commented Nov 2, 2022

Fixed in #3781 and #3767

@rtibbles rtibbles closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P0 - critical Priority: Release blocker or regression
Projects
None yet
4 participants