Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test cleanup for completion/duration tests #4183

Open
marcellamaki opened this issue Jul 4, 2023 · 0 comments
Open

Test cleanup for completion/duration tests #4183

marcellamaki opened this issue Jul 4, 2023 · 0 comments

Comments

@marcellamaki
Copy link
Member

It'd be good to place this outside of the describe('getCompletionCriteriaLabels') block, because it doesn't test, neither describe behavior of getCompletionCriteriaLabels function like other tests cases but rather that of getCompletionDataFromNode. This applies to another new test case below as well.

A nice way to try out if tests organizations and descriptions make sense from the documentation point of view is to run the test suite with --verbose flag and read through the output

yarn test-jest channelEdit/__tests__/utils.spec --verbose

Screenshot from 2023-07-04 07-54-35

And this is nitpick (squared), on the screenshot above you can also see that it may be nice to distinguish between audio and video test cases descriptions to be able to say which one corresponds to which as right now, their names are identical. If one of them failed, ideally we'd be able to say immediately if it fails for video or for audio without digging deep into the tests code.

Originally posted by @MisRob in #4182 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant