Skip to content
This repository has been archived by the owner on Mar 12, 2023. It is now read-only.

Moved to Heroku #2

Open
mohebifar opened this issue Sep 3, 2016 · 3 comments
Open

Moved to Heroku #2

mohebifar opened this issue Sep 3, 2016 · 3 comments

Comments

@mohebifar
Copy link
Member

I made a new web app for Lebab with React deployed on Heroku. From now on, updating Lebab is as simple as updating the version in package.json then pushing to Heroku.

Currently it's hosted only on Heroku but I will update this repo soon as well.

@nene I would also like to give you access to the app on Heroku. Please give me your email address if you want.

@nene
Copy link
Contributor

nene commented Sep 4, 2016

You can use [email protected]

@nene
Copy link
Contributor

nene commented Sep 12, 2016

@mohebifar So finally tried out this Heroku thing, but things didn't work out for me.

I did:

$ heroku git:clone -a lebabjs
$ cd lebabjs
$ npm install

The install finished with an error:

ERROR in ./~/react-codemirror/src/codemirror.js
Module parse failed: /Users/nene/work/lebabjs/node_modules/react-codemirror/src/codemirror.js Unexpected token (76:3)
You may need an appropriate loader to handle this file type.
SyntaxError: Unexpected token (76:3)

The same happens when I run the npm run build script separately. For some reason it's loading code from src/codemirror.js and failing with JSX syntax, while it actually should take code from lib/Codemirror.js.

I got it to build by removing the import and usage of CodeMirror component form the code.

After that I was able to run npm run start, but of course all the CodeMirror editors were missing.

@mohebifar
Copy link
Member Author

I didn't spent much time on creating the new website and the code is not that good. Of course there are a lot of issues with it. In terms of that problem you've encountered with, I have no idea.

I wanted it to have the page generated on the server so I made an isomorphic structure around React using racket. As long as we do not have any back-end, this sort of isomorphic implementation is not necessary and generating static website out of the React code would be enough.

As a suggestion, we can create a better website using create-react-app and Phenomic and move it back to github pages. That's how postcss.org works.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants