Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inability to access OU with ampersand sign (&) in its name #215

Open
pokotilenko opened this issue Jul 25, 2023 · 1 comment
Open

Inability to access OU with ampersand sign (&) in its name #215

pokotilenko opened this issue Jul 25, 2023 · 1 comment
Labels
old Old version of PLA, may not be fixed.

Comments

@pokotilenko
Copy link

Describe the bug

PLA is not able to access OU with ampersand sign (&) in its name. Child objects of such OU are not accessible too. This is probably not limited to OUs.

To Reproduce
Steps to reproduce the behavior:

  1. Go to https://old-demo.phpldapadmin.org, log-in as admin
  2. Click on dc=example.com
  3. Click on Create a child entry
  4. Select Generic: Organisational Unit
  5. Enter Test OU and click Create Object, then click Commit
  6. Click on Create a child entry
  7. Select Generic: Organisational Unit
  8. Enter Ampersand & Fun and click Create Object, then click Commit
  9. You already see error message No such entry (ou=Ampersand & Fun,ou=Test OU,dc=example.com)
  10. Click Refresh
  11. Expand Test OU
  12. You can see Ampersand & Fun OU under Test OU OU which is expected
  13. Now if you click on Ampersand & Fun to open it you get same error No such entry (ou=Ampersand & Fun,ou=Test OU,dc=example.com)

Expected behavior

Newly created OU with ampersand in its name successfully opens after creation and later by clicking on it in a tree.

Screenshots

изображение

Desktop (please complete the following information):

  • OS: ALL
  • Browser ALL
  • Version ALL
@bendem
Copy link

bendem commented Jul 28, 2023

Too aggressive escaping strikes again. The values that PLA receives are immediately escaped before any other processing, which causes this. The correct fix would be to only escape when displaying them, but that's going to be very hard to do this without regressions.

@leenooks leenooks added the old Old version of PLA, may not be fixed. label Aug 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
old Old version of PLA, may not be fixed.
Projects
None yet
Development

No branches or pull requests

3 participants