Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftwm-theme update is not updating - code online will not be downloaded #52

Open
arcolinuxz opened this issue Mar 23, 2022 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed pri-high

Comments

@arcolinuxz
Copy link

May I ask to make it a priority so that we can update our leftwm themes?

We have discussed this before.
Now we do git clone at the start if I am not mistaken. That works like a charm.

We can do a git pull if we update the themes. That works fine if there are no changes locally.

What happens if a user has changed something? What do we do then?

I have a instance where the user has changed his readme.
I want to update the leftwm theme and the readme does not get imported.

ArcoLinux-2022-03-23_07-06

Trying to be part of the solution here. Thinking out loud.

if the theme has changed online we can give users the choice to make a backup yes/no

sometimes you just have changed the font size of background color and it is not worth the hazzle to even have a back up and I would say (No) and then git clone again from scratch so we have the last code in (we know this works great) - so not "git reset --hard" but git clone ...

if yes then we make a backup of that folder and alert the user of that fact - with meld you can compare both folders then and git clone again from the net - since that works

@arcolinuxz arcolinuxz changed the title Leftwm update is not updating - code online will not be downloaded Leftwm-theme update is not updating - code online will not be downloaded Mar 23, 2022
@mautamu mautamu added enhancement New feature or request help wanted Extra attention is needed pri-high labels Mar 24, 2022
@mautamu
Copy link
Member

mautamu commented Mar 24, 2022

Leftwm-theme update is analogous to apt-get update, it doesn’t actually download repositories, just a listing of repositories. Does leftwm-theme upgrade not do this already?

Is leftwm-theme not pulling known.toml properly now?

I agree with the behavior, though off the top of my head I’m not sure what leftwm-theme will do.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed pri-high
Projects
None yet
Development

No branches or pull requests

2 participants