Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

preview option support #37

Closed
Mogost opened this issue Jun 30, 2022 · 17 comments
Closed

preview option support #37

Mogost opened this issue Jun 30, 2022 · 17 comments

Comments

@Mogost
Copy link

Mogost commented Jun 30, 2022

intellij-blackconnect does not respect blacks preview option

preview = true

https://black.readthedocs.io/en/stable/the_black_code_style/future_style.html#preview-style

@lensvol
Copy link
Owner

lensvol commented Jul 28, 2022

Sorry for the late reply, I was on vacation.

Sadly, the problem here is that there is no way to pass this option to the blackd itself, see protocol documentation. :(

I am thinking about making it possible via a commit there, but it may take some time. Until then the issue will be closed as not being the fault of the plugin itself.

@lensvol lensvol closed this as completed Jul 28, 2022
@Mogost
Copy link
Author

Mogost commented Jul 28, 2022

Ouch. I didn't know blackd didn't have support for this. It seems to be just an oversight on their part.
Should I create an issue in black github? Looks very easy to resolve

@lensvol
Copy link
Owner

lensvol commented Jul 28, 2022

Please do. As soon as it is merged I'll get right down to implementing it.

@Mogost
Copy link
Author

Mogost commented Aug 13, 2022

Will be added in the next release of black. I think this can be reopened

@KotlinIsland
Copy link
Contributor

KotlinIsland commented Sep 1, 2022

Black 22.8.0 was released with this addition, this feature can be implemented now 🚀🚀🚀

@Mogost
Copy link
Author

Mogost commented Sep 1, 2022

Hopefully this will be fixed soon. In fact, this is a blocking problem for me.
Since I am using the preview style in my project.
And intellij-blackconnect formats the code and in some files it formats differently than just running black. Then I don't notice changes, push to a repo and CI tests fall :)

@KotlinIsland
Copy link
Contributor

@lensvol
Copy link
Owner

lensvol commented Sep 5, 2022

Yes, hopefully I can get around to implementing that feature this week.

@lensvol lensvol reopened this Sep 5, 2022
@KotlinIsland
Copy link
Contributor

I've just implemented it

@KotlinIsland
Copy link
Contributor

Requesting feedback for the PR: #52

@lensvol
Copy link
Owner

lensvol commented Sep 10, 2022

Solved by #52

@lensvol lensvol closed this as completed Sep 10, 2022
@Mogost
Copy link
Author

Mogost commented Sep 12, 2022

Could we have a new release with this fix?

@lensvol
Copy link
Owner

lensvol commented Sep 12, 2022

There is a possibility that a new patch-level release will be ready in a couple of days. Please be patient.

@Mogost
Copy link
Author

Mogost commented Jan 26, 2023

@lensvol Sorry for pinging again. Could we have a release?

@lensvol
Copy link
Owner

lensvol commented Jan 26, 2023

sigh I really should do that, yes.

Will try to implement support for 3.11 and release before this week ends.

@lensvol
Copy link
Owner

lensvol commented Jan 30, 2023

@Mogost It has been released.

@Mogost
Copy link
Author

Mogost commented Jan 31, 2023

@lensvol thank you for your present for my birthday 😃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants