-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
To use system variables Output clock plugin. #4901
Comments
Mmm, IMHO, this situation can better be handled via Rules. Anything this plugin offers can be done using rules, and probably more flexible too. Edit: The rules syntax would be like:
|
Hello Ton, |
What timer plugin do you mean? |
I mean [p043] clock plugin... (sorry i got confused because in tasmota it is called timer ) |
We don't "steal" from Tasmota, we just borrow :) |
What do you mean... who said anything about stealing 😁 |
I've thought out a possible solution for handling |
It's not the kind of UI as available in Tasmota, but I've made it possible to store, retrieve and process the Clock time configurations having @mariolazarov Can you test please, once this GH Actions run is completed? NB: The format for |
Well, that would be a downgrade in features, and as that's not backward compatible, we can't go that way. I'll think of how to possibly combine this with the existing feature set. |
I understand though it would be nice to have an option to use system variables. Thanks for the comprehensive answer and for the attitude. |
Well, that'll be a challenge, the value is stored as a |
@tonhuisman At least you have some bits left, so in theory, you could allow for a few variables like |
But since this plugin gets changed: Can we remove the "change way the plugin works when no GPIO is selected"- feature. |
That's usually the reason for this kind of special features, and I can see a use for this when not having a GPIO configured. You just need to handle the event for that in Rules, and then you want to know what line in the settings you're triggered from. |
That's exactly what I had in mind when I started the thread. Now this plugin is much more flexible and useful. Thank you guys for the good work. |
Well, I've done some more improvements 😺 (parts suggested by TD-er)
|
@tonhuisman is it possible to add an option for changing to the "GPIO is used" layout when no GPIO is used. Background: A friend asked me (great timing) if i could add a timer option to his battery cabinet i am building right now (it´s my second one :) ) It´s the first time i created a PCB :) (now i am asking myself why i did not do this much, much earlier) |
@chromoxdor Is this what you intended? (No option, just an alternative, more basic, layout) |
In my case, it has been working for three days now, it turns on and off the lights in the yard of my home right on time. Thanks again for the good work. |
You don't have to close this issue, it will be auto-closed by Github when the pull request is merged, as I linked that to this issue. |
Looks good :) |
Sorry I didn't expect it to be a problem. I am satisfied with the result of my question and I think that what I proposed was achieved |
There is no problem. I hijacked your feature request :) . I should have probably posted this directly in the PR. Sorry... |
No problem for me, if you have other ideas, go for it ;) |
And make it even more confusing? 🤣 |
Output clock variables like %sunset% or %sunrise% to be used instate of hh:mm.
The text was updated successfully, but these errors were encountered: