Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dotfile install is removing browser config #311

Open
Stefgug opened this issue Jan 27, 2025 · 1 comment
Open

Dotfile install is removing browser config #311

Stefgug opened this issue Jan 27, 2025 · 1 comment
Labels

Comments

@Stefgug
Copy link

Stefgug commented Jan 27, 2025

In windows setup,"Linking your default browser to Ubuntu" is before the Dotfiles section. So the exports to .zshrc for the $BROWSER and $GH_BROWSER are lost during the zsh install.sh (a zshrc.backup is created though).

Easy fix would be to move the "Linking your default browser to Ubuntu" after the Dotfiles section.

@julesvanrie
Copy link
Contributor

Note to self: moving it down will break the gh authentication instructions (won't open the browser automatically).

So would need to change those instructions which could become confusing (macOS would be different from Windows - don't feel like splitting up the partial).

Or do a double config (might get messy).

To align with WebDev setup. Reusing partials from lewagon/setup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants