Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elixir 1.18 support #846

Open
scohen opened this issue Dec 23, 2024 · 1 comment · May be fixed by #849
Open

Elixir 1.18 support #846

scohen opened this issue Dec 23, 2024 · 1 comment · May be fixed by #849

Comments

@scohen
Copy link
Collaborator

scohen commented Dec 23, 2024

Lexical should support 1.18.
@akagr
Copy link

akagr commented Dec 27, 2024

I ran mix package after making the following change and so far it's been chugging along nicely.

diff --git a/apps/server/lib/lexical/server/boot.ex b/apps/server/lib/lexical/server/boot.ex
index 2a5df77..0cc7f0c 100644
--- a/apps/server/lib/lexical/server/boot.ex
+++ b/apps/server/lib/lexical/server/boot.ex
@@ -88,7 +88,8 @@ defmodule Lexical.Server.Boot do
     "1.15.0" => ">= 1.15.3",
     "1.16.0" => ">= 1.16.0",
     "1.17.0-rc" => ">= 1.17.0-rc",
-    "1.17.0" => ">= 1.17.0"
+    "1.17.0" => ">= 1.17.0",
+    "1.18.0" => ">= 1.18.0"
   }
   @allowed_erlang %{
     "24" => ">= 24.3.4",

@kevinschweikert kevinschweikert mentioned this issue Dec 27, 2024
Closed
@scohen scohen linked a pull request Dec 27, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@scohen @akagr