-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sync Maven dependencies with Gradle dependencies #1311
Comments
We actually have a script for this, written by @housengw: https://github.com/lf-lang/lingua-franca/blob/c742392a3a0d7e9be680ac65ed8c138b411c90e9/bin/bump-versions |
There are 3 action items:
At the moment I don't see a reason to bump the Kotlin version altogether. |
After some investigation I found that the Maven configuration is actually correct and specifies the same kotlin version as the one used in gradle. However, it appears that instead the Ecipse plugin is used for building the Kotlin files and it ships a much older version of Eclipse ( I am not sure how to resolve this. One option would be to revert the Kotlin version in our gradle configuration to This is closely related to lf-lang/epoch#10 as the underlying issue is the same, but it actually extends it to all platforms. Also tagging @a-sr on this. |
I was aware that the Kotlin plugin ships an outdated version but I hoped it would not cause any severe problems. |
This is hugely appreciated, @a-sr. Thanks for undertaking this! |
It appears that Maven uses a Kotlin version below 1.5 while in gradle we use Kotlin 1.6.20. This surfaced because #1218 made use of the
lowercase
function introduced in Kotlin 1.5. But in the corresponding CI run (https://github.com/lf-lang/lingua-franca/runs/7590796430?check_suite_focus=true) the Maven build fails. The kotlin versions should be synchronized between both build systems. While we are at it, we should also double check all other dependencies.The text was updated successfully, but these errors were encountered: