Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the arguments of all our command line tools #1641

Closed
cmnrd opened this issue Mar 10, 2023 · 3 comments · Fixed by #1668
Closed

Test the arguments of all our command line tools #1641

cmnrd opened this issue Mar 10, 2023 · 3 comments · Fixed by #1668
Assignees
Labels

Comments

@cmnrd
Copy link
Collaborator

cmnrd commented Mar 10, 2023

The bug fixed in #1631 showed that our current CLI tests are merely smoke tests and not sufficient to detect if arguments are passed properly and have the intended effect. We should add thorough tests for all command line arguments.

@patilatharva
Copy link
Collaborator

Would it be possible to run a select few unit tests from org.lflang.tests using the existing CliToolTestFixture? Or do you think we should just write new tests specifically for the CLI?

@cmnrd
Copy link
Collaborator Author

cmnrd commented Mar 11, 2023

I think so, yes. When writing the issue, I forgot that @oowekyala already made a start at this. I think it only makes sense to build on this and add tests for all the command line arguments. Most important is, that the tests indeed verify the outcome of the argument. Are interested in taking a shot at this @patilatharva?

@patilatharva
Copy link
Collaborator

Yes, I'll give it a try using the existing CliToolTestFixture!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants