Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add linter and ensure that code is warning-free #268

Open
lhstrh opened this issue Sep 1, 2023 · 1 comment
Open

Add linter and ensure that code is warning-free #268

lhstrh opened this issue Sep 1, 2023 · 1 comment

Comments

@lhstrh
Copy link
Member

lhstrh commented Sep 1, 2023

(...) [we] could just copy the clang-format and clang-tidy setup from reactor-cpp.

Originally posted by @cmnrd in lf-lang/lingua-franca#1806 (comment)
@petervdonovan
Copy link
Contributor

Bumping this as a reaction to #323, which is an example of a PR that mixes changes to complex code with (lots of) formatting improvements. Manual formatting improvements are great, but we can reduce the risk of missing important changes amidst formatting-related noise if we automate formatting before embarking on more big PRs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhstrh @petervdonovan