Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dedup reaction triggers #25

Closed
jhaye opened this issue Aug 1, 2022 · 2 comments
Closed

Dedup reaction triggers #25

jhaye opened this issue Aug 1, 2022 · 2 comments
Labels
bug Something isn't working

Comments

@jhaye
Copy link
Collaborator

jhaye commented Aug 1, 2022

lf-lang/lingua-franca#1228 contains a test called ReadOutputOfContainedBank for which the last reaction, that has two triggers, fires twice. It should only be called once however, since triggers should be deduplicated.

@jhaye jhaye added the bug Something isn't working label Aug 1, 2022
@oowekyala
Copy link
Collaborator

I wonder if #28 might fix this. The problem there was a merge of a reaction into the wrong level. This is the only way AFAIK that a reaction may execute twice at the same time step, since reactions at the same level are already deduplicated.

@jhaye
Copy link
Collaborator Author

jhaye commented Sep 6, 2022

I just tried it and it seems like it does!

@cmnrd cmnrd closed this as completed Sep 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants