Fix portfolio

[Marchand-Nicolas]

Description 📹

Fix the portfolio loading issue in app/[addressOrDomain]/page.tsx and services/argentPortfolioService.ts due to changes in the portfolio API. Test the functionality on the page /0x05f1f8de723d8117daa26ec24320d0eacabc53a3d642acb0880846486e73283a, verifying the API calls in the network tab. Check how the new API works by checking the network tab of the console on https://portfolio.argent.xyz/overview/0x05f1f8de723d8117daa26ec24320d0eacabc53a3d642acb0880846486e73283a.
The portfiolio code is in app/[addressOrDomain]/page.tsx around line 768

Proposed Actions 🛠️

Here’s a checklist of actions to follow for resolving this issue:

1. Fork and Create Branch:
   Fork the repository and create a new branch using the issue number:

   git checkout -b fix-[issue-number]

2. Implement Changes:

   • Update app/[addressOrDomain]/page.tsx to handle the updated API response structure.
   • Update services/argentPortfolioService.ts to reflect the new API endpoints and adapt the functions (fetchTokens, fetchUserTokens, fetchUserDapps, etc.) accordingly.
   • Ensure the new API headers and parameters match the new API documentation.
   • Test the API calls on the provided URL and check for any failed requests in the network tab.
   • Compare the behavior with the reference implementation at https://portfolio.argent.xyz/overview/... to ensure accuracy.
   • Fix any potential issues caused by changes in the API, such as token balances, dapp data, or price calculations.
   • Add any new error handling to ensure robust functionality with the updated API.

3. Run Tests and Commit Changes:
   Make sure your changes don't break existing functionality and commit with a clear message:

   git commit -m "Fix: Portfolio API update for Argent portfolio loading"

Required 📋

To keep our workflow smooth, please make sure you follow these guidelines:

• Assignment: Don't create a pull request if you weren’t assigned to this issue.
• Timeframe: Complete the task within 3 business days.
• Closing the Issue: In your PR description, close the issue by writing Close #[issue_id].
• Review Process:
  • Once you've submitted your PR, change the label to "ready for review".
  • If changes are requested, address them and then update the label back to "ready for review" once done.
• Testing: Test your PR locally before pushing, and verify that tests and build are working after pushing.

Thank you for your contribution 🙏

⚠️ WARNING: Failure to follow the requirements above may result in being added to the OnlyDust blacklist, affecting your ability to receive future rewards.

[Benjtalkshow]

Hi @Marchand-Nicolas
Give a chance to handle this task. thanks

[Michaelkingsdev]

@Marchand-Nicolas
Can i be assigned to this task?

[emarc99]

I would love to do this, sir. ETA 3 days.

[blessingbytes]

Can I tackle this issue

[MaiCVCR]

Hi, I'm Mai, a developer with several years of experience. I appreciate the opportunity to contribute to this project.
I can fix and test the issue on the portfolio loading page to ensure it aligns with the latest API changes.

[wheval]

Hello, I'm Wheval an experienced frontend Developer and Opensource Contributor.
I have experience working with Typescript, Nextjs and Reactjs.

I would love toe work on this, I would use the network tab to investigate the issue, then fix it properly.

I would ensure the error is fixed before making a PR.

ETA is 1 day.

[Emmanex01]

I'd be happy to do this.
I'm Emmanuel Tochukwu, frontend and smart contract developer. I have experience building projects using JavaScript, Cairo, Tailwindcss, Typescript and Nextjs. If given this issue, I will deliver as soon as possible.

[akintewe]

Hello everyone, I am a Frontend developer. I have studied the requirements and would love to take this issue as my first, I would love to work on this issue, as a new contributor. Thank you so much My ETA is 8 hours. Really Excited

[omsant02]

i would like to take this issue

ETA : 1 day

[DaPrice1]

Hello everyone, greetings and salutations, I'm a New contributor and I would really love to contribute to this project, I'd like to take this issue only because I know and I am truly more than capable enough.

The problem the app is facing is a portfolio loading issue due to recent changes in the portfolio API. This affects app/[addressOrDomain]/page.tsx (around line 768) and services/argentPortfolioService.ts.

My action Plan would be to;

1. Investigate API Changes: I would check how the updated API behaves via the network tab at Argent Portfolio Overview.
2. Update the Code: I would modify app/[addressOrDomain]/page.tsx and services/argentPortfolioService.ts to align with the updated API structure.
3. Test the Fix: I would thoroughly verify functionality on /0x05f1f8de723d8117daa26ec24320d0eacabc53a3d642acb0880846486e73283a.
   Use the network tab to ensure correct API calls and responses.

My goal would be to resolve the loading issue while ensuring the app correctly integrates with the updated portfolio API, maintaining smooth and accurate data display.

DaPrice1

[Elite-tch]

Can I attempt this issue?

[AdejareSamad]

I'd love to work on this!

[Amarjeet325]

May I be assigned to this?

[pablomadrigal]

I'm Pablo Madrigal.

I'm a Fullstack Developer with more than 5 years of experience primarily on React and Node.js and now learning web3, I'm also part of Dojo Coding ⛩️

Problem

Fix portfolio

Solution

Update app/[addressOrDomain]/page.tsx and  services/argentPortfolioService.ts to reflect the new API endpoints response structures and adapt the functions (fetchTokens, fetchUserTokens, fetchUserDapps, etc.) accordingly.

ETA: 2 days

Steps

1. Update app/[addressOrDomain]/page.tsx

2. Update services/argentPortfolioService.ts

3. Ensure the API matches the new API documentation

4. Test the API calls on the provided URL

5. Fix other issues that appear in the moment

6. Add error handling

7. Update the test