-
Notifications
You must be signed in to change notification settings - Fork 162
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Reorganized wallet pop-up to show uninstalled wallets last #932
Comments
I'd love to work on this! |
Is it okay if I take this? as i have previously worked on this |
hello, @fricoben!. I’d love to work on this task. ETA is 5 hours. |
Hi @fricoben can I please work on this |
I'd like to take this issue. |
I’d like to help with this. |
I'd love to give this a go. |
May I be assigned to this? |
I'd like to take this issue. |
I'd like to apply to this issue |
Hello @fricoben |
I'd love to work on this sir @fricoben . |
Let me try this one! I am a full stack developer and have experience in javascript and typescript |
I am looking forward to contributing to this. |
Hello @fricoben , I'm very interested in contributing! it's a simple task, but it will help me familiarize myself with the code, because I want to contribute further in the project! I'm interested to be an active contributor!). |
Could I take a shot at this? |
I'd love to give this a go. |
Could I try solving this? |
Is it okay if I take this? |
Can I start working on this? |
My Background and How It Can Be Leveraged How I Plan on Tackling This Issue Function Refactoring: Conditional Sorting Logic: Identify connectors like OKX and Bitget by their unique identifiers. Code Readability and Documentation: Expected Benefits I look forward to applying this structured solution and contributing to a more streamlined and user-centric application experience! |
Is it okay if I take this? |
hey @fricoben can i hop on this issue?? |
Hi @fricoben, I’m Kevin Latino, a frontend developer and a Dojo Coding Member. I’ll complete this issue in 3 hours. To resolve it, I’ll adjust the wallet sorting logic to ensure uninstalled wallets, specifically OKX and Bitget, appear last in the wallet list of the pop-up. By reusing the existing sortConnectors function, I’ll make sure that installed wallets like Argent and Braavos appear first, while uninstalled wallets are moved to the end. Although I’m a contributor, my contribution was just adding an image. I’d now love to contribute with some actual code! :) |
I’m interested in this one. |
Mind if I take this issue? |
@Villarley assigned to you :) |
Thank you so much, I'm working on it!🤲 |
OKX and Bitget wallets are not installed and should then be showed in the last position instead of right after argent/braavos
You can reuse the
sortConnectors
function hereThe text was updated successfully, but these errors were encountered: