Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorganized wallet pop-up to show uninstalled wallets last #932

Closed
fricoben opened this issue Nov 7, 2024 · 28 comments · Fixed by #945
Closed

Reorganized wallet pop-up to show uninstalled wallets last #932

fricoben opened this issue Nov 7, 2024 · 28 comments · Fixed by #945
Assignees
Labels
Good first issue Good for newcomers open for contribution An issue that is available for an Only Dust contribution

Comments

@fricoben
Copy link
Contributor

fricoben commented Nov 7, 2024

Capture d’écran 2024-11-07 à 11 24 36

OKX and Bitget wallets are not installed and should then be showed in the last position instead of right after argent/braavos

You can reuse the sortConnectors function here

@fricoben fricoben added open for contribution An issue that is available for an Only Dust contribution Good first issue Good for newcomers labels Nov 7, 2024
@0xdevcollins
Copy link
Contributor

I'd love to work on this!

@jaiminRaiyani
Copy link
Contributor

jaiminRaiyani commented Nov 7, 2024

Is it okay if I take this? as i have previously worked on this

@wheval
Copy link
Contributor

wheval commented Nov 7, 2024

hello, @fricoben!.

I’d love to work on this task.

ETA is 5 hours.

@ShantelPeters
Copy link
Contributor

Hi @fricoben can I please work on this

@sajalbnl
Copy link
Contributor

sajalbnl commented Nov 7, 2024

I'd like to take this issue.

@Shaarps
Copy link
Contributor

Shaarps commented Nov 7, 2024

I’d like to help with this.

@Snehagupta1907
Copy link
Contributor

I'd love to give this a go.

@mimisavage
Copy link

May I be assigned to this?

@caxtonacollins
Copy link
Contributor

I'd like to take this issue.

@godekina
Copy link
Contributor

godekina commented Nov 7, 2024

I'd like to apply to this issue

@Michaelkingsdev
Copy link

Hello @fricoben
Can i work on this one? It will be my first time contributing to this project.

@Benjtalkshow
Copy link
Contributor

I'd love to work on this sir @fricoben .

@Aditya-040
Copy link
Contributor

Let me try this one! I am a full stack developer and have experience in javascript and typescript

@ooochoche
Copy link

I am looking forward to contributing to this.

@tasneemtoolba
Copy link
Contributor

tasneemtoolba commented Nov 7, 2024

Hello @fricoben , I'm very interested in contributing! it's a simple task, but it will help me familiarize myself with the code, because I want to contribute further in the project! I'm interested to be an active contributor!).

@Great7-dev
Copy link

Could I take a shot at this?

@genamol
Copy link

genamol commented Nov 7, 2024

I'd love to give this a go.

@DanielEmmanuel1
Copy link

Could I try solving this?
I am a returning contributor to the project I can get this delievered in 24 hrs

@ivancano
Copy link

ivancano commented Nov 7, 2024

Is it okay if I take this?

@pheobeayo
Copy link

Can I start working on this?

@Villarley
Copy link
Contributor

My Background and How It Can Be Leveraged
I am Santiago Villarreal Arley, a dedicated software developer with a keen interest in Web3 technologies and decentralized applications. Recently, I have worked on various projects, such as BuildMyEvent, an open-source blockchain initiative, that required meticulous problem-solving and strategic feature integration. I am passionate about creating well-organized code structures and optimizing user experience. I aim to bring these skills to the current challenge of connector sorting, ensuring efficient and user-friendly access to wallet options within the application.

How I Plan on Tackling This Issue
I’m excited to address the connector sorting issue to ensure a more organized and intuitive user experience in selecting Web3 wallets within the app. Here’s the approach I propose:

Function Refactoring:
I will leverage the existing sortConnectors function to make the sorting logic more flexible and adaptable. I’ll update it to conditionally place specific connectors, such as OKX and Bitget, at the end of the list when they’re not installed, preserving the intended order.

Conditional Sorting Logic:
The function will be modified to:

Identify connectors like OKX and Bitget by their unique identifiers.
Place them at the end of the list only when their available() method returns false.
Otherwise, maintain the default order based on availability.

Code Readability and Documentation:
To maintain code clarity, I’ll add inline comments explaining the purpose and reasoning behind the conditional sorting. This will help in future maintenance and ensure other developers can quickly understand the logic.

Expected Benefits
This update will enhance user experience by presenting a cleaner and more predictable list of wallet options, improving usability and reducing potential confusion. Additionally, by reusing and refining existing code, the solution will align with project standards, maximizing maintainability and consistency.

I look forward to applying this structured solution and contributing to a more streamlined and user-centric application experience!

@Akshola00
Copy link
Contributor

Is it okay if I take this?

@vestor-dev
Copy link

vestor-dev commented Nov 7, 2024

hey @fricoben can i hop on this issue??
would like to be a contributor

@KevinLatino
Copy link
Contributor

Hi @fricoben,

I’m Kevin Latino, a frontend developer and a Dojo Coding Member.

I’ll complete this issue in 3 hours.

To resolve it, I’ll adjust the wallet sorting logic to ensure uninstalled wallets, specifically OKX and Bitget, appear last in the wallet list of the pop-up. By reusing the existing sortConnectors function, I’ll make sure that installed wallets like Argent and Braavos appear first, while uninstalled wallets are moved to the end.

Although I’m a contributor, my contribution was just adding an image. I’d now love to contribute with some actual code! :)

@DevJSter
Copy link

DevJSter commented Nov 8, 2024

I’m interested in this one.

@GradleD
Copy link
Contributor

GradleD commented Nov 9, 2024

Mind if I take this issue?

@fricoben
Copy link
Contributor Author

@Villarley assigned to you :)

@Villarley
Copy link
Contributor

@Villarley assigned to you :)

Thank you so much, I'm working on it!🤲

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Good first issue Good for newcomers open for contribution An issue that is available for an Only Dust contribution
Projects
None yet
Development

Successfully merging a pull request may close this issue.