Code tidy-up (reduce unnecessary if statements in for loops) #85
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this file I noticed a for loop counting from 0..columns and subsequently doing nothing at index 0. In other words the loop spent doing a good number of unnecessary checks just because the starting point wasn't right.
I went over the rest of the file as well to further reduce unnecessary if statements inside loops which should enhance code efficiency, albeit sometimes at the cost of (partially) repeating code. I imagine speed may not be the top priority in this particular file, in which case no worries, but just pointing out that initial weirdness.