You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Aug 19, 2022. It is now read-only.
Changes to go's error messages causing tests to fail.
To reproduce:
go get golang.org/dl/go1.14
go1.14 download
go1.14 test
test output
```
Running Suite: libp2p TLS Suite
===============================
Random Seed: 1584021139
Will run 22 of 22 specs
••••Initializing a server using an secp256k1 key: 16Uiu2HAmLvCzPwmReGvF6REB3HArNciMEhDAAozCTxKaswNrth9e
Initializing a client using an RSA key: QmRF7LKTb4mCeK2HqiBCituuoe3frDe9Va2wBh6b2GA5AR
• Failure [1.086 seconds]
Transport
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:37
invalid certificates
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:191
fails if the client presents an invalid cert: private key used in the TLS handshake doesn't match the public key in the cert [It]
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:374
Expected
<string>: tls: invalid signature by the client certificate: ECDSA verification failure
to equal
<string>: tls: invalid certificate signature
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:388
Initializing a server using an ECDSA key: QmSwmN69qi5SB1dLKyWUYFH4QmraFtMJsiE4HejJMjMVXf
Initializing a client using an ECDSA key: QmS8fyvTR9HV9JoKt42Sv3EwSYAo1iL8vrgojTnV5TeDtY
• Failure [0.003 seconds]
Transport
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:37
invalid certificates
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:191
fails if the server presents an invalid cert: private key used in the TLS handshake doesn't match the public key in the cert [It]
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:404
Expected
<string>: tls: invalid signature by the server certificate: ECDSA verification failure
to equal
<string>: tls: invalid certificate signature
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:424
••Initializing a server using an secp256k1 key: 16Uiu2HAm72ytjXz8dCzP9QWvYQnh1tAhFTDVbxZ2wNzdGCJ3Z8Wb
Initializing a client using an ECDSA key: QmWbWDHGA7zjq29CipEz9GQf1oeGRpk8N3nxw1yNA1YWDn
• Failure [1.018 seconds]
Transport
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:37
invalid certificates
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:191
fails if the client presents an invalid cert: cert is expired [It]
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:374
Expected
<string>: "...valid: curr..."
to equal |
<string>: "...valid"
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:388
Initializing a server using an ECDSA key: QmU8PgQqSvAtVf6Zc1W4AoUoK6ZE7CyRYW9w6R3Rk9PekS
Initializing a client using an ECDSA key: QmdHT9ZjYgvuTcZqU6AwpNY5Js5qga6Wa7N1vsj6oHyqvm
• Failure [0.003 seconds]
Transport
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:37
invalid certificates
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:191
fails if the server presents an invalid cert: cert is expired [It]
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:404
Expected
<string>: "...valid: curr..."
to equal |
<string>: "...valid"
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:424
••••••••••••
Summarizing 4 Failures:
[Fail] Transport invalid certificates [It] fails if the client presents an invalid cert: private key used in the TLS handshake doesn't match the public key in the cert
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:388
[Fail] Transport invalid certificates [It] fails if the server presents an invalid cert: private key used in the TLS handshake doesn't match the public key in the cert
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:424
[Fail] Transport invalid certificates [It] fails if the client presents an invalid cert: cert is expired
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:388
[Fail] Transport invalid certificates [It] fails if the server presents an invalid cert: cert is expired
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:424
Ran 22 of 22 Specs in 2.778 seconds
FAIL! -- 18 Passed | 4 Failed | 0 Pending | 0 Skipped
--- FAIL: TestLibp2pTLS (2.78s)
FAIL
exit status 1
FAIL github.com/RTradeLtd/go-libp2p-tls 2.902s
</details>
The text was updated successfully, but these errors were encountered:
xiegeo
changed the title
Test fail in go 1.14
Tests fail in go 1.14
Mar 12, 2020
Changes to go's error messages causing tests to fail.
To reproduce:
go get golang.org/dl/go1.14 go1.14 download go1.14 test
test output
``` Running Suite: libp2p TLS Suite =============================== Random Seed: 1584021139 Will run 22 of 22 specs••••Initializing a server using an secp256k1 key: 16Uiu2HAmLvCzPwmReGvF6REB3HArNciMEhDAAozCTxKaswNrth9e
Initializing a client using an RSA key: QmRF7LKTb4mCeK2HqiBCituuoe3frDe9Va2wBh6b2GA5AR
• Failure [1.086 seconds]
Transport
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:37
invalid certificates
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:191
fails if the client presents an invalid cert: private key used in the TLS handshake doesn't match the public key in the cert [It]
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:374
Initializing a server using an ECDSA key: QmSwmN69qi5SB1dLKyWUYFH4QmraFtMJsiE4HejJMjMVXf
Initializing a client using an ECDSA key: QmS8fyvTR9HV9JoKt42Sv3EwSYAo1iL8vrgojTnV5TeDtY
• Failure [0.003 seconds]
Transport
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:37
invalid certificates
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:191
fails if the server presents an invalid cert: private key used in the TLS handshake doesn't match the public key in the cert [It]
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:404
••Initializing a server using an secp256k1 key: 16Uiu2HAm72ytjXz8dCzP9QWvYQnh1tAhFTDVbxZ2wNzdGCJ3Z8Wb
Initializing a client using an ECDSA key: QmWbWDHGA7zjq29CipEz9GQf1oeGRpk8N3nxw1yNA1YWDn
• Failure [1.018 seconds]
Transport
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:37
invalid certificates
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:191
fails if the client presents an invalid cert: cert is expired [It]
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:374
Initializing a server using an ECDSA key: QmU8PgQqSvAtVf6Zc1W4AoUoK6ZE7CyRYW9w6R3Rk9PekS
Initializing a client using an ECDSA key: QmdHT9ZjYgvuTcZqU6AwpNY5Js5qga6Wa7N1vsj6oHyqvm
• Failure [0.003 seconds]
Transport
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:37
invalid certificates
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:191
fails if the server presents an invalid cert: cert is expired [It]
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:404
••••••••••••
Summarizing 4 Failures:
[Fail] Transport invalid certificates [It] fails if the client presents an invalid cert: private key used in the TLS handshake doesn't match the public key in the cert
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:388
[Fail] Transport invalid certificates [It] fails if the server presents an invalid cert: private key used in the TLS handshake doesn't match the public key in the cert
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:424
[Fail] Transport invalid certificates [It] fails if the client presents an invalid cert: cert is expired
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:388
[Fail] Transport invalid certificates [It] fails if the server presents an invalid cert: cert is expired
/mnt/c/Users/xiege/go/src/github.com/RTradeLtd/go-libp2p-tls/transport_test.go:424
Ran 22 of 22 Specs in 2.778 seconds
FAIL! -- 18 Passed | 4 Failed | 0 Pending | 0 Skipped
--- FAIL: TestLibp2pTLS (2.78s)
FAIL
exit status 1
FAIL github.com/RTradeLtd/go-libp2p-tls 2.902s
The text was updated successfully, but these errors were encountered: