Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

webtransport: put custom WebTransport code in the (basic)host and observed address manager #2235

Closed
Tracked by #2236
p-shahi opened this issue Apr 3, 2023 · 0 comments

Comments

@p-shahi
Copy link
Member

p-shahi commented Apr 3, 2023

          We could do the most minimal thing here, which is a bit hacky:
             1. Add a helper func `RemoveCerthashes`.
             2. ObservedAddrManager Calls `RemoveCerthashes` before comparing things.
             3. basic_host will copy cerrthashes to webtransport addrs before returning multiaddrs from `Addrs`. This way conusmers of an addr get the correct and up to date webtransport addrs.
          It's hacky because 1 & 3 involve these components having special knowledge of the whole system. But it would probably be the fastest and smallest short term fix. And we could write a test for the behavior to protect against a future regression.

Originally posted by @MarcoPolo in #2233 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant