This repository has been archived by the owner on Jun 26, 2023. It is now read-only.
feat!: change stream muxer interface #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not seeing how its blocking this PR |
Npm build fails 😅 |
|
Is this blocked by #278 ? |
achingbrain
added a commit
to libp2p/js-libp2p-mplex
that referenced
this pull request
Aug 6, 2022
To make sure there's no chance we end up copying memory to a new location only to pass it to a stream handler, return `Uint8ArrayList`s for the `data` property of multiplexed messages. The stream interface looks like this: ``` Stream extends Duplex<Uint8ArrayList, Uint8ArrayList | Uint8Array> ``` That is, it's a Duplex whose source emits `Uint8ArrayList`s but the sink can accept `Uint8ArrayList`s or `Uint8Arrays`. Depends on: - [ ] libp2p/js-libp2p-interfaces#279
1 task
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2022
## [@libp2p/interface-metrics-v3.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-metrics-v2.0.0...@libp2p/interface-metrics-v3.0.0) (2022-08-07) ### ⚠ BREAKING CHANGES * change stream muxer interface (#279) ### Features * change stream muxer interface ([#279](#279)) ([1ebe269](1ebe269)) ### Trivial Changes * update project config ([#271](#271)) ([59c0bf5](59c0bf5))
|
🎉 This PR is included in version @libp2p/interface-metrics-v3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2022
## [@libp2p/interface-connection-v3.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-connection-v2.1.1...@libp2p/interface-connection-v3.0.0) (2022-08-07) ### ⚠ BREAKING CHANGES * change stream muxer interface (#279) * change connection encryption interface to uint8arraylist (#278) ### Features * change connection encryption interface to uint8arraylist ([#278](#278)) ([1fa580c](1fa580c)) * change stream muxer interface ([#279](#279)) ([1ebe269](1ebe269)) ### Trivial Changes * update project config ([#271](#271)) ([59c0bf5](59c0bf5))
|
🎉 This PR is included in version @libp2p/interface-connection-v3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2022
## [@libp2p/interface-stream-muxer-compliance-tests-v4.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-stream-muxer-compliance-tests-v3.0.1...@libp2p/interface-stream-muxer-compliance-tests-v4.0.0) (2022-08-07) ### ⚠ BREAKING CHANGES * change stream muxer interface (#279) ### Features * change stream muxer interface ([#279](#279)) ([1ebe269](1ebe269)) ### Trivial Changes * update project config ([#271](#271)) ([59c0bf5](59c0bf5)) ### Dependencies * update sibling dependencies ([f859920](f859920))
|
🎉 This PR is included in version @libp2p/interface-stream-muxer-compliance-tests-v4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 7, 2022
## [@libp2p/interface-mocks-v4.0.0](https://github.com/libp2p/js-libp2p-interfaces/compare/@libp2p/interface-mocks-v3.0.3...@libp2p/interface-mocks-v4.0.0) (2022-08-07) ### ⚠ BREAKING CHANGES * change stream muxer interface (#279) * change connection encryption interface to uint8arraylist (#278) ### Features * change connection encryption interface to uint8arraylist ([#278](#278)) ([1fa580c](1fa580c)) * change stream muxer interface ([#279](#279)) ([1ebe269](1ebe269)) ### Dependencies * update sibling dependencies ([f75e927](f75e927)) * update sibling dependencies ([d98a5ea](d98a5ea)) * update sibling dependencies ([f859920](f859920)) * update sibling dependencies ([93a89b1](93a89b1))
|
🎉 This PR is included in version @libp2p/interface-mocks-v4.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@wemeetagain @achingbrain multistream-select is blocking updating muxer interface to use uint8arraylist