Skip to content
This repository has been archived by the owner on Jul 21, 2023. It is now read-only.

Random Walk (previously Bootstrap) is not started by default, why? #26

Closed
daviddias opened this issue Mar 15, 2018 · 3 comments
Closed
Labels
kind/support A question or request for support

Comments

@daviddias
Copy link
Member

@dignifiedquire do you happen to remember why you never auto start random-walk neither here on in js-libp2p?

@daviddias daviddias added status/ready Ready to be worked kind/support A question or request for support labels Mar 19, 2018
@vasco-santos
Copy link
Member

I have only now checked that this issue already existed.

In the tests that I am currently implementing for DHT Interop, I cannot have peers getting to know each other until I start the random walk. In GO land, their random walk is started immediately.

I already created two PRs for enabling this js-libp2p-kad-dht#42 and js-libp2p#251.

@dignifiedquire do you have any feedback on this?

@daviddias
Copy link
Member Author

@vasco-santos you have to have in mind that when go-libp2p DHT was built, there was still no concept of libp2p and therefore Peer Routing and Content Routing. When designing libp2p we made those explicitly separate and that is why this module gets 3 badges https://github.com/libp2p/js-libp2p-kad-dht#peer-routing

@vasco-santos
Copy link
Member

Ok, this makes sense to be started by its users, if they intend to (like in js-libp2p)! Thanks David

I will close this issue for now.

@ghost ghost removed the status/ready Ready to be worked label Sep 25, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/support A question or request for support
Projects
None yet
Development

No branches or pull requests

2 participants