Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: Allow cancellation of pending dials in queue #1822

Closed
maschad opened this issue Jun 15, 2023 · 1 comment
Closed

Feat: Allow cancellation of pending dials in queue #1822

maschad opened this issue Jun 15, 2023 · 1 comment

Comments

@maschad
Copy link
Member

maschad commented Jun 15, 2023

Following up from the conversation here consider adding a cancel method to remove a pending dial from the queue and reject all promises waiting on it.

@maschad maschad added the need/triage Needs initial labeling and prioritization label Jun 15, 2023
@maschad maschad moved this to 🥞Weekly Candidates/Discuss🎙 in js-libp2p Jun 15, 2023
@maschad maschad self-assigned this Jun 28, 2023
@maschad maschad moved this from 🥞Weekly Candidates/Discuss🎙 to 🛠️ Todo in js-libp2p Jun 28, 2023
@maschad maschad removed the need/triage Needs initial labeling and prioritization label Jun 28, 2023
@maschad maschad removed their assignment Aug 14, 2023
@p-shahi p-shahi moved this from 🛠️ Todo to 🪵Backlog in js-libp2p Aug 15, 2023
@achingbrain
Copy link
Member

Closing as this hasn't come up again after (almost) a year. The more common use case is to cancel the operation that caused the dial to get added to the queue, rather than yanking the rug out from under the operation.

@github-project-automation github-project-automation bot moved this from 🪵Backlog to 🎉Done in js-libp2p May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

No branches or pull requests

2 participants