Inlined latency-monitor code

[wemeetagain]

• Version: master
• Platform: *
• Subsystem: connection-manager

Type: Question

Severity: Low

Description:

In reviewing / investigating ChainSafe/js-libp2p-gossipsub#86, I'd remembered that the libp2p connection manager contained some sort of "latency monitoring" which might be used to resolve this issue.
Upon further review, it became clear that the code from the latency-monitor package/repo had been inlined in this repo in #587, possibly to reduce the bundle size.

Should this library be inlined? (Are there other libraries also inlined?)
Should libp2p rely on the upstream library?

[vasco-santos]

I am not really sure about the reasoning for this.

@jacobheun @hugomrdias can you help here?

[hugomrdias]

This package is mostly unmaintained and should actually be refactored or removed, at the time of #587 pushing the changes needed upstream would be unlikely so we decided to just inline. But this should not be our general approach to external dependencies.

[lidel]

I believe https://discuss.libp2p.io is a better place for asking questions (keeping github limited to actionalble issues/bug reports)