-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Medley of pubsub
improvements
#283
Comments
@pacrob I would like to discuss the 1st topic in this issue, are we still considering to use |
It looks like there was some discussion on the async topic in #174 and #383. I personally only have experience with Moving forward, let's continue with the |
I have been originally using asyncio on some machine learning orchestration code that I was making, I don't have enough insight into libp2p's codebase to make a value judgement, other than to say that I have been waiting for libp2p's codebase to become more mature so that I can implement it for internode communication and filesharing. |
I believe using Trio is the shared goal from our previous contributors and we should continue using it cause there is no such need as of now to migrate, I will look further into this issue keeping Trio in mind, if it's okay with everyone. |
Leaving this here while I'm reviewing the current
pubsub
packages...Don't serialize message sends, eg: https://github.com/libp2p/py-libp2p/blob/master/libp2p/pubsub/gossipsub.py#L172-L177
Happens here and in
floodsub
as well -- this is a great place to useasyncio.gather
"separate policy from mechanism" -- in the same place, we defer to the particular
router
to decide who to send new msgs to... and then do the sending in the router itself. as far as i can tell, we can pull out the sending part into thePubsub
class, relying on therouter
for what should be its only job -- determining peers for some actionThe text was updated successfully, but these errors were encountered: