Drop support for async-std
?
#4286
Replies: 3 comments 3 replies
-
Can I take from this that the recommendation is to use |
Beta Was this translation helpful? Give feedback.
-
As we spoke in the community call, agree with the decision Thomas |
Beta Was this translation helpful? Give feedback.
-
I've opened #4449 as one action item from this discussion. At a later point, we can decide whether we want to actually drop support for it. |
Beta Was this translation helpful? Give feedback.
-
I'd like to discuss the idea of dropping support for
async-std
.Benefits:
Disadvantages:
async-std
need to start a separate tokio runtime to uselibp2p
tokio
is a much more actively maintained library.async-std
has not had a release in over a year and even the previous ones were rather minor: https://github.com/async-rs/async-std/releasesI'd suggest that we still have a
tokio
feature flag (this is important for WASM compilation). Thus, I believe there would be no footguns around running on the wrong executor.Due to the modular nature of things, support for
async-std
could also be maintained out-of-tree if someone is interested.Beta Was this translation helpful? Give feedback.
All reactions