Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revisit peer-id string representation #423

Open
wemeetagain opened this issue Jun 22, 2022 · 4 comments
Open

Revisit peer-id string representation #423

wemeetagain opened this issue Jun 22, 2022 · 4 comments

Comments

@wemeetagain
Copy link
Member

See https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md#string-representation

Specifically:

Libp2p is slowly transitioning from the first (legacy) format to the second (new).

and

Implementations SHOULD display peer IDs using the first (raw base58btc encoded multihash) format until the second format is widely supported.

Perhaps its time this language is changed to be more definitively in favor of the 'new' encoding.
Opening issue for discussion.

@mxinden
Copy link
Member

mxinden commented Jun 23, 2022

Referencing tracking issue here: #216

@burdiyan
Copy link

Would be great to have some guidance on this one. We (Mintter) currently store and work with PeerIDs in the CID form, but it often causes issues with debugging, because logs and everything else in the ecosystem is still using the multihash form of PeerIDs.

Using the CID form in the IPLD data also sometimes causes problems when looking at the IPLD data using the IPLD Explorer UI — it treats those as IPLD links (which is fair), but complains about not being able to resolve or decode data using the libp2p-key CID codec.

@mxinden
Copy link
Member

mxinden commented Apr 17, 2023

@burdiyan I don't think Thomas or I will prioritize this any time soon. That said, happy to guide you contributing this change.

@burdiyan
Copy link

My point was mostly to get some recommendations about which PeerID forms to use storing in IPLD, keeping in memory, outputting in the UI and CLI?

@dhuseby dhuseby moved this to Triage in libp2p Specs May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Triage
Development

No branches or pull requests

3 participants