-
Notifications
You must be signed in to change notification settings - Fork 280
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revisit peer-id string representation #423
Comments
Referencing tracking issue here: #216 |
Would be great to have some guidance on this one. We (Mintter) currently store and work with PeerIDs in the CID form, but it often causes issues with debugging, because logs and everything else in the ecosystem is still using the multihash form of PeerIDs. Using the CID form in the IPLD data also sometimes causes problems when looking at the IPLD data using the IPLD Explorer UI — it treats those as IPLD links (which is fair), but complains about not being able to resolve or decode data using the libp2p-key CID codec. |
@burdiyan I don't think Thomas or I will prioritize this any time soon. That said, happy to guide you contributing this change. |
My point was mostly to get some recommendations about which PeerID forms to use storing in IPLD, keeping in memory, outputting in the UI and CLI? |
See https://github.com/libp2p/specs/blob/master/peer-ids/peer-ids.md#string-representation
Specifically:
and
Perhaps its time this language is changed to be more definitively in favor of the 'new' encoding.
Opening issue for discussion.
The text was updated successfully, but these errors were encountered: