Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rust-libp2p build breaks on master's update #43

Closed
laurentsenta opened this issue Sep 19, 2022 · 2 comments · Fixed by #45
Closed

rust-libp2p build breaks on master's update #43

laurentsenta opened this issue Sep 19, 2022 · 2 comments · Fixed by #45

Comments

@laurentsenta
Copy link
Collaborator

the worfklow started to fail in go-libp2p, here is an example of a run:
https://github.com/libp2p/go-libp2p/actions/runs/3047048099/jobs/4910594908

Raised by @marten-seemann

We need to investigate, my first intuition:

Now that we merged: #37
We are using "latest" release and not master.

We expect that when rust release a new version and updates master, that won't break other tests (because we only test releases known by libp2p/test-plans).

BUT we do use a master definition in the Cargo file, this is how we deal with multiple versions:

libp2pv0480 = {package = "libp2p", git = "https://github.com/libp2p/rust-libp2p", branch = "master", default_features = false, features = [ "websocket", "mplex", "yamux", "tcp-async-io", "ping", "noise", "dns-async-std" ], version = "0.48.0", optional = true}

That line will break if the package is bumped to version 0.49 because it will try to load the repo and won't find the 0.48 version.

We might need to drop this line and use a rewrite in the master group.

@mxinden
Copy link
Member

mxinden commented Sep 21, 2022

We might need to drop this line and use a rewrite in the master group.

Off the top of my head, this sounds reasonable to me.

@laurentsenta
Copy link
Collaborator Author

Thanks for the input @mxinden,
this should get the CI back to green, that's my current priority,

Related note: libp2p/rust-libp2p#2813 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants