Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Screen lock features/fixes #4375

Closed
3 tasks done
luckkmaxx opened this issue Aug 5, 2023 · 1 comment
Closed
3 tasks done

Screen lock features/fixes #4375

luckkmaxx opened this issue Aug 5, 2023 · 1 comment
Labels
discussion Should be discussed first enhancement New feature or request

Comments

@luckkmaxx
Copy link
Contributor

Describe your suggested feature

Lock button not only should lock controls.

  1. When you have auto-rotation enabled, the locked screen will exit to normal mode if you hand your phone in portrait. So you can do anything but touch video controls.
  2. The statusbar also shouldnt be shown when locker. But it can only be hidden, but not disabled AFAIK due to Android limitations.

The idea is to make the lock screen option more kids-proof.

Other details

No response

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@luckkmaxx luckkmaxx added the enhancement New feature or request label Aug 5, 2023
@Bnyro Bnyro added the discussion Should be discussed first label Aug 5, 2023
@Bnyro
Copy link
Member

Bnyro commented Aug 7, 2023

Concerning 1.: I don't think rotating the phone should unlock the player. Since you can lock the player in fullscreen and in normal portrait mode, it would likely be inconvenient, since the expected behavior is to remember preferences, even when the screen rotates.

@Bnyro Bnyro closed this as completed Aug 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discussion Should be discussed first enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants