Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weird player behavior in landscape mode #5986

Closed
3 tasks done
DanielProg39 opened this issue May 6, 2024 · 3 comments · Fixed by #5992
Closed
3 tasks done

Weird player behavior in landscape mode #5986

DanielProg39 opened this issue May 6, 2024 · 3 comments · Fixed by #5992
Labels
bug Something isn't working

Comments

@DanielProg39
Copy link

Steps to reproduce

  1. Enable autorotation for the app interface and the player
  2. When holding phone horizontally, open a video

Expected behavior

Video should open in full-screen.

Actual behavior

Video opens in strange layout that stays the same in any orientation.

LibreTube version

LibreTube Debug, commit 096ab60

Android version

Android 13

Other details

Recording:

2_5316953110520812717.mp4

Acknowledgements

  • I have searched the existing issues and this is a new ticket, NOT a duplicate or related to another open issue.
  • I have written a short but informative title.
  • I will fill out all of the requested information in this form.
@DanielProg39 DanielProg39 added the bug Something isn't working label May 6, 2024
@Bnyro
Copy link
Member

Bnyro commented May 6, 2024

Video opens in strange layout that stays the same in any orientation.

That's not a 'strange layout', it's the landscape layout of the player page :)

Though it shouldn't stay when rotating the phone.

@DanielProg39
Copy link
Author

DanielProg39 commented May 6, 2024

OK, but how do I enter the full-screen mode with this layout?

Edit: by swiping, I didn't think of it at first.

@DanielProg39
Copy link
Author

Autorotation for player disables the button for entering full-screen mode. I think I get it - it's not straight away bug (however, layout not changing for vertical orientation is a bug), but it seems that these two settings break each other. I think the perfect solution would be that when the UI is horizontal and auto full screen is enabled, the video should open in full screen mode but have a button to exit it. And that button should only be missing when the UI layout is strictly vertical.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants