From 8a069ec6dfc914adc3a811008054a9c181345a70 Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 17 Jan 2025 00:02:40 +0100 Subject: [PATCH 1/2] Fix navigating back home --- .../libretube/ui/fragments/HomeFragment.kt | 11 +++-- app/src/main/res/navigation/nav.xml | 47 ++++++++++++++----- 2 files changed, 42 insertions(+), 16 deletions(-) diff --git a/app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt b/app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt index 6f1af6acd8..5e1cc71237 100644 --- a/app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt +++ b/app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt @@ -35,6 +35,7 @@ import com.github.libretube.ui.models.HomeViewModel import com.github.libretube.ui.models.SubscriptionsViewModel import com.google.android.material.snackbar.Snackbar + class HomeFragment : Fragment() { private var _binding: FragmentHomeBinding? = null private val binding get() = _binding!! @@ -64,23 +65,23 @@ class HomeFragment : Fragment() { } binding.featuredTV.setOnClickListener { - findNavController().navigate(R.id.subscriptionsFragment) + findNavController().navigate(R.id.action_homeFragment_to_libraryFragment) } binding.watchingTV.setOnClickListener { - findNavController().navigate(R.id.watchHistoryFragment) + findNavController().navigate(R.id.action_homeFragment_to_watchHistoryFragment) } binding.trendingTV.setOnClickListener { - findNavController().navigate(R.id.trendsFragment) + findNavController().navigate(R.id.action_homeFragment_to_trendsFragment) } binding.playlistsTV.setOnClickListener { - findNavController().navigate(R.id.libraryFragment) + findNavController().navigate(R.id.action_homeFragment_to_libraryFragment) } binding.bookmarksTV.setOnClickListener { - findNavController().navigate(R.id.libraryFragment) + findNavController().navigate(R.id.action_homeFragment_to_libraryFragment) } binding.refresh.setOnRefreshListener { diff --git a/app/src/main/res/navigation/nav.xml b/app/src/main/res/navigation/nav.xml index 9ec3352d5d..0093a24322 100644 --- a/app/src/main/res/navigation/nav.xml +++ b/app/src/main/res/navigation/nav.xml @@ -8,7 +8,29 @@ android:id="@+id/homeFragment" android:name="com.github.libretube.ui.fragments.HomeFragment" android:label="fragment_home" - tools:layout="@layout/fragment_home" /> + tools:layout="@layout/fragment_home"> + + + + + tools:layout="@layout/fragment_channel"> + app:nullable="true" /> + app:nullable="true" /> + app:nullable="false" /> - - - \ No newline at end of file From 03782fd0b550f0385468b7658343f744d99b22c7 Mon Sep 17 00:00:00 2001 From: Thomas Date: Fri, 17 Jan 2025 00:02:40 +0100 Subject: [PATCH 2/2] Fix navigating back home --- .../libretube/ui/fragments/HomeFragment.kt | 11 ++-- app/src/main/res/navigation/nav.xml | 54 +++++++++++++++---- 2 files changed, 49 insertions(+), 16 deletions(-) diff --git a/app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt b/app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt index 6f1af6acd8..858aed9d8c 100644 --- a/app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt +++ b/app/src/main/java/com/github/libretube/ui/fragments/HomeFragment.kt @@ -35,6 +35,7 @@ import com.github.libretube.ui.models.HomeViewModel import com.github.libretube.ui.models.SubscriptionsViewModel import com.google.android.material.snackbar.Snackbar + class HomeFragment : Fragment() { private var _binding: FragmentHomeBinding? = null private val binding get() = _binding!! @@ -64,23 +65,23 @@ class HomeFragment : Fragment() { } binding.featuredTV.setOnClickListener { - findNavController().navigate(R.id.subscriptionsFragment) + findNavController().navigate(R.id.action_homeFragment_to_subscriptionsFragment) } binding.watchingTV.setOnClickListener { - findNavController().navigate(R.id.watchHistoryFragment) + findNavController().navigate(R.id.action_homeFragment_to_watchHistoryFragment) } binding.trendingTV.setOnClickListener { - findNavController().navigate(R.id.trendsFragment) + findNavController().navigate(R.id.action_homeFragment_to_trendsFragment) } binding.playlistsTV.setOnClickListener { - findNavController().navigate(R.id.libraryFragment) + findNavController().navigate(R.id.action_homeFragment_to_libraryFragment) } binding.bookmarksTV.setOnClickListener { - findNavController().navigate(R.id.libraryFragment) + findNavController().navigate(R.id.action_homeFragment_to_libraryFragment) } binding.refresh.setOnRefreshListener { diff --git a/app/src/main/res/navigation/nav.xml b/app/src/main/res/navigation/nav.xml index 9ec3352d5d..efbb0c9601 100644 --- a/app/src/main/res/navigation/nav.xml +++ b/app/src/main/res/navigation/nav.xml @@ -8,7 +8,36 @@ android:id="@+id/homeFragment" android:name="com.github.libretube.ui.fragments.HomeFragment" android:label="fragment_home" - tools:layout="@layout/fragment_home" /> + tools:layout="@layout/fragment_home"> + + + + + + tools:layout="@layout/fragment_channel"> + app:nullable="true" /> + app:nullable="true" /> + app:nullable="false" /> - - - \ No newline at end of file