Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversations add-on: DKIM status indicator not shown in new tabs #454

Open
LRitzdorf opened this issue Aug 7, 2024 · 4 comments
Open
Labels
compatibility Related to a specific Thunderbird version or another add-on

Comments

@LRitzdorf
Copy link

When opening an email in a new tab, no DKIM status indicator is displayed. For the same messages, when viewed in Thunderbird's message pane (i.e. the one that's toggled by F8), indicators are displayed as expected.

This seems to have the same symptoms as #172, in case that's relevant. Happy to provide further logs/troubleshooting details!

@lieser
Copy link
Owner

lieser commented Aug 13, 2024

Just tried to reproduce it but was not able to.
Could you please tell which version of Thunderbird and the add-on you are using?

Also is where any error visible in the error console of Thunderbird? https://github.com/lieser/dkim_verifier/wiki/Debug#view-error-and-debug-messages

@lieser lieser added the bug Something isn't working label Aug 13, 2024
@LRitzdorf
Copy link
Author

Aha, this is apparently due to interaction with Thunderbird Conversations. I've found #203, which seems at least a little relevant. Also, using Thunderbird's default reader view ("Open in classic reader") does display DKIM labeling appropriately.

The deviation from what I'd expect, then, is that the "pill" label is not included in Thunderbird Conversations' new-tab view (see below).

Message pane Tabbed view
image image

I'm currently on Thunderbird 115.14.0, with DKIM Verifier 5.4.0 and Thunderbird Conversations 4.1.7.

@lieser
Copy link
Owner

lieser commented Sep 10, 2024

I will try to fix this incompatibility in the next version.

@lieser lieser added the compatibility Related to a specific Thunderbird version or another add-on label Sep 10, 2024
@lieser lieser added this to the 5.5.0 milestone Sep 10, 2024
@lieser
Copy link
Owner

lieser commented Jan 1, 2025

@Standard8 I just briefly looked into this and it seems like when opening an e-mail via double click in a new tab and the Thunderbird Conversations view opens, the browser.messageDisplay.onMessagesDisplayed listener is not called.

I don't remember exactly how it behaved in the past, but if I read https://github.com/thunderbird-conversations/thunderbird-conversations/wiki/Integration-with-other-add-ons#for-authors-of-other-add-ons correctly that has always been the case and so far still no alternative exist?

Tested with Conversations 4.2.3 and TB 135.0a1 (2025-01-01)


A little off topic: the normal message pane view did no longer show the content of any message when I click on one in the list. Neither the classic or the Conversations view opens,
Don't know if I just configured something wrong or this is a new issue for Conversations.

@lieser lieser changed the title DKIM status indicator not shown in new tabs Conversations add-on: DKIM status indicator not shown in new tabs Jan 1, 2025
@lieser lieser removed the bug Something isn't working label Jan 4, 2025
@lieser lieser removed this from the 5.5.0 milestone Jan 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compatibility Related to a specific Thunderbird version or another add-on
Projects
None yet
Development

No branches or pull requests

2 participants