-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature request: add ability to show note about DKIM being missing, perhaps with some icon added #464
Comments
Note that you can already set in the display option to always show the DKIM header (https://github.com/lieser/dkim_verifier/wiki/Display-Options#show-dkim-header), which when result in I think what you are asking for: Also I would recommended to have a look at the sign rules the add-on provides (https://github.com/lieser/dkim_verifier/wiki/Sign-rules). |
My apologies that I missed the option to always show it, that's very useful! But I would still suggest that there should be warning icons, and particularly one for "No signature" as well so it stands out. Is there an option for that as well, or would it be possible to add? Maybe it's just me, but I think showing a warning icon for that case would make sense as a default setting. |
Where is currently no option to shown an icon, and I don't think I will add one by default. I could still leave this open as a feature request to make it configurable. But unless this will get some more votes unlikely I would implement it myself. |
@ell1e unsure if your +1 to my last comment meant that you want to keep this open as a feature request in the hope others will vote for it, or if it is ok to close it. |
I think it makes sense to keep around. You recently mentioned not wanting the user to be overwhelmed by false alerts, for example, and having info presented primarily via a lengthier text without a simple icon seems like a similar potential pitfall. Therefore I still think this would be a great addition if somebody gets around to it some day, especially if combined with #452 so it'll be limited to relevant signatures. But of course I'm biased. Feel free to close it if you disagree. |
I love this extension so far! But i noticed when DKIM is missing rather than invalid, so either no
Authentication-Results
header or it saysdkim=none
and either local DKIM check disabled or there's no DKIM signature header, there doesn't seem to be an obvious marker which maybe should be there.It would help if 1. missing was also always shown (at least as an option), and 2. clear icons would be placed next to the DKIM state, e.g. like this:
(I stole the icons from firefox for the purpose of a quick mockup)
The text was updated successfully, but these errors were encountered: