Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: add ability to show note about DKIM being missing, perhaps with some icon added #464

Open
ell1e opened this issue Oct 6, 2024 · 5 comments
Labels
enhancement Improvements or new features prio:low Unlikely work will happen on this unless someone contributes it

Comments

@ell1e
Copy link

ell1e commented Oct 6, 2024

I love this extension so far! But i noticed when DKIM is missing rather than invalid, so either no Authentication-Results header or it says dkim=none and either local DKIM check disabled or there's no DKIM signature header, there doesn't seem to be an obvious marker which maybe should be there.

It would help if 1. missing was also always shown (at least as an option), and 2. clear icons would be placed next to the DKIM state, e.g. like this:

Screenshot_20241006_144053

Screenshot_20241006_144053_2

(I stole the icons from firefox for the purpose of a quick mockup)

@lieser
Copy link
Owner

lieser commented Oct 7, 2024

Note that you can already set in the display option to always show the DKIM header (https://github.com/lieser/dkim_verifier/wiki/Display-Options#show-dkim-header), which when result in I think what you are asking for:
grafik

Also I would recommended to have a look at the sign rules the add-on provides (https://github.com/lieser/dkim_verifier/wiki/Sign-rules).
This allow to specifying that e-mails from certain domains should always be signed, and if not it would result in an even more visible error.

@lieser lieser added the question label Oct 7, 2024
@ell1e
Copy link
Author

ell1e commented Oct 7, 2024

My apologies that I missed the option to always show it, that's very useful! But I would still suggest that there should be warning icons, and particularly one for "No signature" as well so it stands out. Is there an option for that as well, or would it be possible to add? Maybe it's just me, but I think showing a warning icon for that case would make sense as a default setting.

@lieser
Copy link
Owner

lieser commented Dec 19, 2024

But I would still suggest that there should be warning icons, and particularly one for "No signature" as well so it stands out. Is there an option for that as well, or would it be possible to add?

Where is currently no option to shown an icon, and I don't think I will add one by default.
I think it is more important from who a DKIM signature is than the simple distinction if some random DKIM signature is where or not.

I could still leave this open as a feature request to make it configurable. But unless this will get some more votes unlikely I would implement it myself.

@lieser
Copy link
Owner

lieser commented Jan 5, 2025

@ell1e unsure if your +1 to my last comment meant that you want to keep this open as a feature request in the hope others will vote for it, or if it is ok to close it.

@ell1e
Copy link
Author

ell1e commented Jan 5, 2025

I think it makes sense to keep around. You recently mentioned not wanting the user to be overwhelmed by false alerts, for example, and having info presented primarily via a lengthier text without a simple icon seems like a similar potential pitfall. Therefore I still think this would be a great addition if somebody gets around to it some day, especially if combined with #452 so it'll be limited to relevant signatures.

But of course I'm biased. Feel free to close it if you disagree.

@lieser lieser added enhancement Improvements or new features prio:low Unlikely work will happen on this unless someone contributes it and removed question labels Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements or new features prio:low Unlikely work will happen on this unless someone contributes it
Projects
None yet
Development

No branches or pull requests

2 participants