Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project Template Logos #291

Closed
RehanSaeed opened this issue Aug 10, 2015 · 2 comments
Closed

Project Template Logos #291

RehanSaeed opened this issue Aug 10, 2015 · 2 comments
Labels

Comments

@RehanSaeed
Copy link
Contributor

I noticed looking at the new xUnit project template that there is a PreviewImage logo you can add to the template. Here is an extract of the _project.vstemplate.xml file:

<VSTemplate>
  <TemplateData>
    <!-- Omitted -->
    <Icon>logo-64-transparent.png</Icon>
    <PreviewImage>logo-512-transparent.png</PreviewImage> 
  </TemplateData>
</VSTemplate>

The template also contains three images

  • sw-file-icon.png (64 x 64)
  • logo-64-transparent.png (64 x 64)
  • logo-512-transparent.png (512 x 512)

Why is the sw-file-icon.png there when it is not used? Is the name of this file fixed? When I have other images in the project template for Icon and PreviewImage, they get output as part of the project. How can I stop this from happening?

@RehanSaeed
Copy link
Contributor Author

Ok, looks like sw-file-icon.png is hard coded in ligershark.templates.targets.

I've created this pull request to add sw-file-previewimage.png to the ignored files list.

Is my pull request required? Is there a way to add to this list of ignored files?

@sayedihashimi
Copy link
Member

@RehanSaeed I think we can close this after your changes at ligershark/template-builder#77. Please reopen if we need to do more here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants