Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run the functional tests, to ensure they're correct #427

Closed
dwijnand opened this issue Nov 23, 2019 · 0 comments · Fixed by #444
Closed

Run the functional tests, to ensure they're correct #427

dwijnand opened this issue Nov 23, 2019 · 0 comments · Fixed by #444
Assignees
@dwijnand
Labels
enhancement
Milestone
0.6.3

Comments

@dwijnand
Copy link
Collaborator

dwijnand commented Nov 23, 2019 •
edited
Loading

The "-ok"-suffixed functional tests capture the types of code changes that (we believe) are binary compatible, while the "-nok" tests aren't. #426 is an example where we were wrong. It would be good to try to run the code, as further proof.
@dwijnand dwijnand mentioned this issue Nov 23, 2019
Merged
@dwijnand dwijnand self-assigned this Dec 23, 2019
@dwijnand dwijnand changed the title Run the "ok" tests, to further assert they're ok Run the functional tests, to ensure they're correct Jan 2, 2020
This was referenced Jan 2, 2020
Merged
Merged
Merged
@dwijnand dwijnand mentioned this issue Jan 10, 2020
Merged
@dwijnand dwijnand modified the milestones: 0.6.2, 0.6.3 Feb 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dwijnand dwijnand

Labels
enhancement
Milestone
0.6.3
Development

Successfully merging a pull request may close this issue.

Run the functional tests, to ensure they're correct dwijnand/mima
1 participant
@dwijnand