This repository has been archived by the owner on May 9, 2024. It is now read-only.
forked from apache/spark
-
Notifications
You must be signed in to change notification settings - Fork 3
[SPARK-8975][Streaming] Adds a mechanism to send a new rate from the driver to the block generator #15
Merged
dragos
merged 2 commits into
lightbend:topic/streaming-bp/dynamic-rate
from
huitseeker:SPARK-8975
Jul 17, 2015
Merged
[SPARK-8975][Streaming] Adds a mechanism to send a new rate from the driver to the block generator #15
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
47 changes: 47 additions & 0 deletions
47
streaming/src/test/scala/org/apache/spark/streaming/receiver/RateLimiterSuite.scala
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
/* | ||
* Licensed to the Apache Software Foundation (ASF) under one or more | ||
* contributor license agreements. See the NOTICE file distributed with | ||
* this work for additional information regarding copyright ownership. | ||
* The ASF licenses this file to You under the Apache License, Version 2.0 | ||
* (the "License"); you may not use this file except in compliance with | ||
* the License. You may obtain a copy of the License at | ||
* | ||
* http://www.apache.org/licenses/LICENSE-2.0 | ||
* | ||
* Unless required by applicable law or agreed to in writing, software | ||
* distributed under the License is distributed on an "AS IS" BASIS, | ||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
* See the License for the specific language governing permissions and | ||
* limitations under the License. | ||
*/ | ||
|
||
package org.apache.spark.streaming.receiver | ||
|
||
import org.apache.spark.SparkConf | ||
import org.apache.spark.SparkFunSuite | ||
|
||
/** Testsuite for testing the network receiver behavior */ | ||
class RateLimiterSuite extends SparkFunSuite { | ||
|
||
test("rate limiter initializes even without a maxRate set") { | ||
val conf = new SparkConf() | ||
val rateLimiter = new RateLimiter(conf){} | ||
rateLimiter.updateRate(105) | ||
assert(rateLimiter.currentRateLimit.get == 105) | ||
} | ||
|
||
test("rate limiter updates when below maxRate") { | ||
val conf = new SparkConf().set("spark.streaming.receiver.maxRate", "110") | ||
val rateLimiter = new RateLimiter(conf){} | ||
rateLimiter.updateRate(105) | ||
assert(rateLimiter.currentRateLimit.get == 105) | ||
} | ||
|
||
test("rate limiter stays below maxRate despite large updates") { | ||
val conf = new SparkConf().set("spark.streaming.receiver.maxRate", "100") | ||
val rateLimiter = new RateLimiter(conf){} | ||
rateLimiter.updateRate(105) | ||
assert(rateLimiter.currentRateLimit.get == 100) | ||
} | ||
|
||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These tests are good, but I was more thinking about testing the path from
ReceiverTracker
to rate limiter.