-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make invoice storage optional #51
Comments
Btw, we're currently not storing the invoices, just tracking payment metadata by payment hash. However, maybe we should consider storing the invoice data for the user, which would allow them to retry failed payments without keeping the invoices around themselves. |
Right, I suppose should have phrased as inbound payment metadata. Really should have specified that this is all about inbound payments - for outbound payments I don't think it really needs to be optional, and there indeed its probably useful to store the invoices themselves, at least in part because its the other half of the proof of payment. |
For someone implementing eg an lnurl server or some other server that generates invoices on demand, storing each invoice generated for receiving payments is potentially a large dos issue. Thus, storage should be optional, though storing them is generally useful to see payment status.
The text was updated successfully, but these errors were encountered: