Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make invoice storage optional #51

Open
TheBlueMatt opened this issue Mar 24, 2023 · 2 comments
Open

Make invoice storage optional #51

TheBlueMatt opened this issue Mar 24, 2023 · 2 comments
Milestone

Comments

@TheBlueMatt
Copy link

For someone implementing eg an lnurl server or some other server that generates invoices on demand, storing each invoice generated for receiving payments is potentially a large dos issue. Thus, storage should be optional, though storing them is generally useful to see payment status.

@tnull
Copy link
Collaborator

tnull commented Jun 10, 2023

Btw, we're currently not storing the invoices, just tracking payment metadata by payment hash. However, maybe we should consider storing the invoice data for the user, which would allow them to retry failed payments without keeping the invoices around themselves.

@TheBlueMatt
Copy link
Author

Right, I suppose should have phrased as inbound payment metadata. Really should have specified that this is all about inbound payments - for outbound payments I don't think it really needs to be optional, and there indeed its probably useful to store the invoices themselves, at least in part because its the other half of the proof of payment.

@tnull tnull mentioned this issue Nov 15, 2023
19 tasks
@tnull tnull added this to the 0.3 milestone Nov 15, 2023
@tnull tnull mentioned this issue May 20, 2024
8 tasks
@tnull tnull modified the milestones: 0.3, 0.4 May 20, 2024
@tnull tnull modified the milestones: 0.4, 0.5 Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants